Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange loop in method ConfigurationEntityCheck() #2540

Closed
bschmalhofer opened this issue Sep 29, 2023 · 1 comment
Closed

Strange loop in method ConfigurationEntityCheck() #2540

bschmalhofer opened this issue Sep 29, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

In the admin pages for dynamic fields, there is a check whether there is a conflict with the SysConfig. For this the method Kernel::System::SysConfig::ConfigurationEntityCheck() is used. The method loops over all value entity types when a simple hash lookup would suffice.

The performance implications are most likely neglectable, but unneeded loops are confusing.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Sep 29, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Sep 29, 2023
@bschmalhofer bschmalhofer self-assigned this Sep 29, 2023
bschmalhofer added a commit that referenced this issue Sep 29, 2023
@bschmalhofer
Issue #2540: minor tidying
6f10f4c 
add a couple of code comments
bschmalhofer added a commit that referenced this issue Sep 29, 2023
@bschmalhofer
Issue #2540: eliminate an unnecessary loop
fe6b8ba 
try to use sensible variable names
bschmalhofer added a commit that referenced this issue Sep 29, 2023
@bschmalhofer
Merge pull request #2541 from RotherOSS/issue-#2540-configuration_ent…
0136a9e 
…ity_check

Issue #2540 configuration entity check
@bschmalhofer
Copy link
Contributor Author

The loop has been eliminated, unit tests still look fine. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer