Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: otobo.CheckModules.pl complains about Apache::DBI #258

Closed
bschmalhofer opened this issue Jul 27, 2020 · 3 comments
Closed

Docker: otobo.CheckModules.pl complains about Apache::DBI #258

bschmalhofer opened this issue Jul 27, 2020 · 3 comments
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.3

Comments

@bschmalhofer
Copy link
Contributor

In the SupportData Frontend the CheckModules report is not green. This is probably due to Apache::DBI which is marked as a bundled module. In the docker image Apache::DBI has been explicitly excluded.

Proposed solution: Remove Apache::DBI from Kernel/cpan-lib altogether.
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jul 27, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.3 milestone Jul 27, 2020
@bschmalhofer
Copy link
Contributor Author

For 10.0.2 the plan is to add Apache::DBI again.

bschmalhofer added a commit that referenced this issue Jul 27, 2020
@bschmalhofer
Issue #258: for 10.0.2 keep Apache::DBI
fd3942b 
Keep CheckModules happy
bschmalhofer added a commit that referenced this issue Jul 27, 2020
@bschmalhofer
Merge pull request #260 from RotherOSS/issue-258-keep_apache_dbi
11d9750 
Issue #258: for 10.0.2 keep Apache::DBI
@bschmalhofer
Copy link
Contributor Author

Closing now. Apache::DBI can be removed when #320 is implemented.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Aug 17, 2020 •
edited
Loading

Reopening as there are two problems:

  • the missing Apache::DBI is still reported in the rel-10_1 branch
  • Apache2::Reload is missing from the list of packaged modules in Kernel::System::Environment

So the approach for rel-10_1 is to explicitly handle that case in Kernel::System::Environment.

bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #258: Apache modules not packaged under Docker
3cacf97 
Added missing modules Apache2::Reload and CGI::Apache to the bundled module list
in the non-Docker case.
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Revert "Issue #258: Apache modules not packaged under Docker"
f0083c0 
This reverts commit 3cacf97.
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #258: Apache modules are not bundled in Docker image
79e7796
bschmalhofer added a commit that referenced this issue Aug 17, 2020
@bschmalhofer
Issue #258: enhanced a code comment
129c246
@bschmalhofer bschmalhofer mentioned this issue Dec 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.3
Development

No branches or pull requests
1 participant
@bschmalhofer