Remove Text::Diff::HTML from Kernel/cpan-lib

[bschmalhofer]

Text::Diff::HTMLis loaded only in Kernel::System::Diff but not actually used there. Let's get rid of it.

[bschmalhofer]

Actually Text::Diff::HTML is used in Kernel::System::Diff as a styler that is loaded dynamically. But that style is set for the plain diff, which does not make sense at all. This is not critical at all, as Kernel::System::Diffis unused anyways. So let's go ahead with the removal.

[bschmalhofer]

Done. Diff.t looks fine. Closing this issue.

[bschmalhofer]

See also #1229

[stefanhaerter]

It was discussed wether Text::Diff can also be removed. There is one occurrence in core:

otobo/Kernel/Modules/AdminPackageManager.pm

Lines 96 to 98 in 95a39de

	# do not allow to read file with including .. path (security related)
	$LocalFile =~ s/\.\.//g;
	if ( !$File ) {

otobo/Kernel/Modules/AdminPackageManager.pm

Line 109 in 95a39de

elsif ( !-e $LocalFile ) {

otobo/Kernel/Modules/AdminPackageManager.pm

Lines 120 to 137 in 95a39de

	elsif ( -e $LocalFile ) {
	my $Content = $MainObject->FileRead(
	Location => $LocalFile,
	Mode => 'binmode',
	);
	if ($Content) {
	$MainObject->Require('Text::Diff');
	my $Diff = Text::Diff::diff( \$File, $Content, { STYLE => 'OldStyle' } );
	$LayoutObject->Block(
	Name => "FileDiff",
	Data => {
	Location => $Location,
	Name => $Name,
	Version => $Version,
	Diff => $Diff,
	},
	);
	}

In order to remove Text::Diff, this would have to be rewritten. A suggestion by @bschmalhofer was to use Algorithm::Diff, which is already included as dependency of Text::Diff:

otobo/Kernel/System/Environment.pm

Lines 283 to 292 in 95a39de

	sub BundleModulesDeclarationGet {
	my ($Self) = @_;
	return (
	{
	'Comment' => 'Needed by Text::Diff',
	'Module' => 'Algorithm::Diff',
	'Required' => 1,
	'VersionRequired' => '== 1.1903',
	},