Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructuring and improvements of reference dynamic fields #2648

Closed
stefanhaerter opened this issue Nov 7, 2023 · 1 comment
Closed

Restructuring and improvements of reference dynamic fields #2648

stefanhaerter opened this issue Nov 7, 2023 · 1 comment
Assignees
@stefanhaerter
Labels
enhancement New feature or request
Milestone
OTOBO 11.0

Comments

@stefanhaerter
Copy link
Contributor

Several changes are to be made for dynamic fields of type reference:

  • Make use of field config param 'Multiselect' for consistency and code readability while maintaining current input field mode dropdown
  • Rely on ValueSet and EditFieldValueGet methods of parent class
  • Therefor, adjust EditFieldValueGet of BaseEntity to suit the needs of reference fields
@stefanhaerter stefanhaerter added the enhancement New feature or request label Nov 7, 2023
@stefanhaerter stefanhaerter added this to the OTOBO 11.0 milestone Nov 7, 2023
@stefanhaerter stefanhaerter self-assigned this Nov 7, 2023
stefanhaerter added a commit that referenced this issue Nov 7, 2023
@stefanhaerter
Issue #2648: Introduce multiselect config param for dynamic field ref…
fe023ee 
…erence.

Fix handling of PossibleNone to prevent duplicated empty selection option.
stefanhaerter added a commit that referenced this issue Nov 7, 2023
@stefanhaerter
Issue #2648: DF Reference now uses ValueSet and EditFieldValueGet met…
424d7f3 
…hods of parent class.

Logic in BaseEntity driver adapted to the needs of df reference.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Introduce multiselect config param for dynamic field ref…
0a51746 
…erence.

Fix handling of PossibleNone to prevent duplicated empty selection option.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: DF Reference now uses ValueSet and EditFieldValueGet met…
8019cfa 
…hods of parent class.

Logic in BaseEntity driver adapted to the needs of df reference.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Corrected value and filter handling in agent and referen…
baf4dfe 
…ce df.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Added unit tests for ValueSet and ValueGet for dynamic f…
d9c7ef3 
…ields agent, customer user, customer company and reference.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Corrected names for multivalue tests.
eec42ed
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Added tests for dynamic fields agent, customer company, …
5407e11 
…customer user and reference also to EditFieldValueGet test.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Added tests for dynamic fields agent, customer company, …
9387781 
…customer user and reference also to ReadableValueRender test.
stefanhaerter added a commit that referenced this issue Nov 8, 2023
@stefanhaerter
Issue #2648: Removed helper params again as they are not neccessarry …
aabee2d 
…for these two tests.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Introduce multiselect config param for dynamic field ref…
3b46746 
…erence.

Fix handling of PossibleNone to prevent duplicated empty selection option.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: DF Reference now uses ValueSet and EditFieldValueGet met…
2d6d1d1 
…hods of parent class.

Logic in BaseEntity driver adapted to the needs of df reference.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Corrected value and filter handling in agent and referen…
ba5cfa7 
…ce df.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Added unit tests for ValueSet and ValueGet for dynamic f…
c71e520 
…ields agent, customer user, customer company and reference.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Corrected names for multivalue tests.
edbb94f
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Added tests for dynamic fields agent, customer company, …
d1a0779 
…customer user and reference also to EditFieldValueGet test.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Added tests for dynamic fields agent, customer company, …
3f1958c 
…customer user and reference also to ReadableValueRender test.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Removed helper params again as they are not neccessarry …
a1277ea 
…for these two tests.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Added unit test DisplayValueRender for dynamic fields ag…
0a1cd4c 
…ent, customer user, customer company and reference.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Reintroduced database cleaning as tickets, users etc. ar…
6833e3f 
…e created and need to be cleaned afterwards.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Enabled dynamic field Reference DisplayValueRender to in…
8394870 
…clude empty values which can occur in multivalue case.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Corrected handling of value reducing for DFs date and mu…
e74282b 
…ltiselect.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Ensured that df reference DisplayValueRender returns Lin…
a4769b0 
…k as undef instead as empty string if no link is present.
stefanhaerter added a commit that referenced this issue Nov 9, 2023
@stefanhaerter
Issue #2648: Enabled as useful considered DisplayValueRender tests fo…
a64c57e 
…r normal fieds.

Adjusted df reference tests to previous change in DisplayValueRender.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Introduce multiselect config param for dynamic field ref…
7b861f2 
…erence.

Fix handling of PossibleNone to prevent duplicated empty selection option.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: DF Reference now uses ValueSet and EditFieldValueGet met…
adc3958 
…hods of parent class.

Logic in BaseEntity driver adapted to the needs of df reference.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Corrected value and filter handling in agent and referen…
d4344fc 
…ce df.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Added unit tests for ValueSet and ValueGet for dynamic f…
1604dba 
…ields agent, customer user, customer company and reference.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Corrected names for multivalue tests.
0de1f17
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Added tests for dynamic fields agent, customer company, …
2d6e724 
…customer user and reference also to EditFieldValueGet test.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Added tests for dynamic fields agent, customer company, …
773071c 
…customer user and reference also to ReadableValueRender test.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Removed helper params again as they are not neccessarry …
801ebf7 
…for these two tests.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Added unit test DisplayValueRender for dynamic fields ag…
19d962f 
…ent, customer user, customer company and reference.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Reintroduced database cleaning as tickets, users etc. ar…
204a99c 
…e created and need to be cleaned afterwards.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Enabled dynamic field Reference DisplayValueRender to in…
648a214 
…clude empty values which can occur in multivalue case.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Corrected handling of value reducing for DFs date and mu…
d5e4878 
…ltiselect.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Ensured that df reference DisplayValueRender returns Lin…
a654d17 
…k as undef instead as empty string if no link is present.
svenoe pushed a commit that referenced this issue Nov 9, 2023
@stefanhaerter @svenoe
Issue #2648: Enabled as useful considered DisplayValueRender tests fo…
53c307f 
…r normal fieds.

Adjusted df reference tests to previous change in DisplayValueRender.
@stefanhaerter stefanhaerter mentioned this issue Nov 9, 2023
Merged
@stefanhaerter
Copy link
Contributor Author

Closed with merging #2649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanhaerter stefanhaerter

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@stefanhaerter