Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Locale::Countries from 3.69 to 3.76 #2661

Closed
bschmalhofer opened this issue Nov 9, 2023 · 4 comments
Closed

Update Locale::Countries from 3.69 to 3.76 #2661

bschmalhofer opened this issue Nov 9, 2023 · 4 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

Kernel/cpan-lib/Locale/Country.pm is included in OTOBO because it was removed as a core module in Perl 5.30 (2019) und because Linux distributions may provide old versions. The aim is to keep this up to date. I checked SBECK-github/Locale-Codes@v3.69...v3.76 and found only two significant changes, as far as I understood it:

  • Turkey renamed to Turkiye
  • The Netherlands renamed to Kingdom of the Netherlands

But these changes are not visible in OTOBO. There the countries are still Netherlands and Turkey. Kosovo is still missing.

So I think that the module can be updated.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Nov 9, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Nov 9, 2023
@bschmalhofer bschmalhofer self-assigned this Nov 9, 2023
bschmalhofer added a commit that referenced this issue Nov 9, 2023
@bschmalhofer
Issue #2661: update Locale::Codes to 3.76
4b63f32
@bschmalhofer
Copy link
Contributor Author

See also #674.

bschmalhofer added a commit that referenced this issue Nov 9, 2023
@bschmalhofer
Merge pull request #2662 from RotherOSS/issue-#2661-locale_country
54f34ec 
Issue #2661: update Locale::Codes to 3.76
@bschmalhofer
Copy link
Contributor Author

The module has been updated. Not really tested, but closing the issue anyways.

bschmalhofer added a commit that referenced this issue Nov 15, 2023
@bschmalhofer
Issue #2661: Netherlands renamed to Netherlands (Kingdom of the)
e41ca48
bschmalhofer added a commit that referenced this issue Nov 15, 2023
@bschmalhofer
Issue #2661: testing Turkiye
bec72b5 
recently renamed from Turkey
@bschmalhofer
Copy link
Contributor Author

The test script still needs to be updated.

@bschmalhofer bschmalhofer reopened this Nov 15, 2023
bschmalhofer added a commit that referenced this issue Nov 15, 2023
@bschmalhofer
Merge pull request #2674 from RotherOSS/issue-#2661-netherlands
558a03e 
Issue #2661 netherlands
@bschmalhofer
Copy link
Contributor Author

The test script is updated, to check for "Netherlands (The Kindom of)" and for "Turkiye". Closing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer