Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Provide Open Containers Initiative annotations #277

Closed
bschmalhofer opened this issue Jul 30, 2020 · 6 comments
Closed

Docker: Provide Open Containers Initiative annotations #277

bschmalhofer opened this issue Jul 30, 2020 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@bschmalhofer
Copy link
Contributor

See: https://github.com/opencontainers/image-spec/blob/master/annotations.md .
Looks like this is a convention for labels on docker images.

@bschmalhofer bschmalhofer added the enhancement New feature or request label Jul 30, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 30, 2020
@bschmalhofer bschmalhofer changed the title Docker: Provide Open Containers Initiative anntations Docker: Provide Open Containers Initiative annotations Jul 30, 2020
bschmalhofer added a commit that referenced this issue Aug 30, 2020
Hardcode /opt/otobo_install instead.
bschmalhofer added a commit that referenced this issue Aug 30, 2020
By calling git config --get remote.origin.url in hooks/build
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Aug 30, 2020

@StefanRother-OTOBO , @svenoe

I have adapted the label in https://github.com/RotherOSS/otobo/tree/issue-277-open_containers_initiative. Could you take a look at these labels, whether the changes can be merged into rel-10_0:

                "maintainer": "Team OTOBO <dev@otobo.org>",
                "org.opencontainers.image.authors": "Team OTOBO <dev@otobo.org>",
                "org.opencontainers.image.created": "2020-08-31T07:49:32Z",
                "org.opencontainers.image.description": "OTOBO is the new open source ticket system with strong functionality AND a great look",
                "org.opencontainers.image.documentation": "https://otobo.org",
                "org.opencontainers.image.licenses": "GNU General Public License v3.0 or later",
                "org.opencontainers.image.revision": "cbb08a0f59a47a358fd07ed91484e45466e81ebd",
                "org.opencontainers.image.source": "git@github.com:RotherOSS/otobo.git",
                "org.opencontainers.image.title": "OTOBO",
                "org.opencontainers.image.url": "https://github.com/RotherOSS/otobo",
                "org.opencontainers.image.vendor": "Rother OSS GmbH",
                "org.opencontainers.image.version": "issue-277-open_containers_initiative"

The version is currently the Docker tag. For releases it probably is sensible to normalize rel-10_1_0 to 10.1.0.

@bschmalhofer
Copy link
Contributor Author

Changed "org.opencontainers.image.url" to point to "https://github.com/RotherOSS/otobo".
On second thought I probably would leave "org.opencontainers.image.version" to contain the Docker hub tag, That is rel-10_0_3 instead of 10.0.3. . Looks more consistent to me, as there are also tags for devel versions and maybe other cases.

@StefanRother-OTOBO
Copy link
Contributor

Hi Bernhard,

please implement it the way you think, it sounds perfekt for me.

Stefan

bschmalhofer added a commit that referenced this issue Sep 3, 2020
Reflect what is actually used in hooks/build
@bschmalhofer
Copy link
Contributor Author

Labels look fine in local and in Docker hub builds. Closing the issue.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Sep 18, 2020

Let's backport this to 10.0.3 as the Docker version is starting to get used. TODO:

  • backport
  • check labels of local builds
  • check labels of Docker Hub builds

@bschmalhofer
Copy link
Contributor Author

Labels look fine. Closing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants