Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Zero as valid value for ImportExport Selection value #2797

Closed
stefanhaerter opened this issue Jan 5, 2024 · 1 comment
Closed

Allow Zero as valid value for ImportExport Selection value #2797

stefanhaerter opened this issue Jan 5, 2024 · 1 comment
Assignees
@stefanhaerter
Labels
bug Something isn't working as intended
Milestone
OTOBO 11.0

Comments

@stefanhaerter
Copy link
Contributor

The effect occurs e.g. when selecting 'No' for the attribute 'Include column headers' in the module AdminImportExport. 'No' is mapped to '0', which is correctly stored. But when building the selection from the stored data, the following line overwrites '0' with the default value for the attribute:

otobo/Kernel/Output/HTML/ImportExport/LayoutSelection.pm

Line 91 in 1cc89cf

$Param{Value} ||= $Param{Item}->{Input}->{ValueDefault};

@stefanhaerter stefanhaerter added the bug Something isn't working as intended label Jan 5, 2024
@stefanhaerter stefanhaerter added this to the OTOBO 11.0 milestone Jan 5, 2024
@stefanhaerter stefanhaerter self-assigned this Jan 5, 2024
stefanhaerter added a commit that referenced this issue Jan 5, 2024
@stefanhaerter
Issue #2797: Allowed zero as valid value for ImportExport attribute s…
757c00d 
…election.
@stefanhaerter stefanhaerter mentioned this issue Jan 5, 2024
Merged
svenoe pushed a commit that referenced this issue Jan 8, 2024
@stefanhaerter @svenoe
Issue #2797: Allowed zero as valid value for ImportExport attribute s…
8a4651d 
…election.
@stefanhaerter
Copy link
Contributor Author

Closed with merging #2798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanhaerter stefanhaerter

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@stefanhaerter