Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the BaseArray parameter into a behaviour #2845

Closed
bschmalhofer opened this issue Jan 18, 2024 · 4 comments
Closed

Turn the BaseArray parameter into a behaviour #2845

bschmalhofer opened this issue Jan 18, 2024 · 4 comments
Assignees
@bschmalhofer
Labels
ImportExport Related to Import and Export of data
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

Currently there is a parameter BaseArray that is passed to the method ValueStructureFromDB(). This parameter determines wheter a single value field is returned as a plain scalar or as an arrayref with a single value. This parameter should be replaced by a behavior. The advantage is that the behavior can be inspected from the outside. This is useful e.g. for ImportExport.
@bschmalhofer bschmalhofer added the ImportExport Related to Import and Export of data label Jan 18, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jan 18, 2024
@bschmalhofer bschmalhofer self-assigned this Jan 18, 2024
@bschmalhofer
Copy link
Contributor Author

This has been implemented with corresponding changes in GeneralCatalog and ITMSConfiguration. Let's keep the issue open in case of problems.

bschmalhofer added a commit that referenced this issue Jan 19, 2024
@bschmalhofer
Issue #2845: Replace the argument 'BaseArray'
66460ee 
with the behavior 'IsBaseArray'
bschmalhofer added a commit that referenced this issue Jan 19, 2024
@bschmalhofer
Merge pull request #2853 from RotherOSS/issue-#2845-base_array
4026ecf 
Issue #2845: Replace the argument 'BaseArray'
@bschmalhofer
Copy link
Contributor Author

Closing now as no problems cropped up.

@stefanhaerter
Copy link
Contributor

Note: Perhaps PR #2862 actually belonged to this issue - not entirely sure, but mentioning it nonetheless to have the link between PR and issue.

svenoe pushed a commit that referenced this issue Feb 19, 2024
Issue #2845: Revert "Issue #2845: Replace the argument 'BaseArray'"
66a4c4c 
This reverts commit 66460ee.
@svenoe
Copy link
Contributor

svenoe commented Feb 19, 2024

I reverted this change after a short discussion, as the initial reason for it, ImportExport using this information, was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
ImportExport Related to Import and Export of data
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
3 participants
@bschmalhofer @stefanhaerter @svenoe