Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test failures regarding dynamic fields #2889

Closed
4 tasks done
stefanhaerter opened this issue Jan 26, 2024 · 6 comments
Closed
4 tasks done

Fix unit test failures regarding dynamic fields #2889

stefanhaerter opened this issue Jan 26, 2024 · 6 comments
Assignees
@stefanhaerter
Labels
unittests Requests wrt unittests
Milestone
OTOBO 11.0

Comments

@stefanhaerter
Copy link
Contributor

stefanhaerter commented Jan 26, 2024 •
edited
Loading

Currently failing are:

  • scripts/test/DynamicField/Backend.t
  • scripts/test/DynamicField/EditFieldRender.t
  • scripts/test/DynamicField/EditFieldValueGet.t
  • scripts/test/Selenium/Customer/DynamicFields/DynamicFieldDatabase.t
@stefanhaerter stefanhaerter added the unittests Requests wrt unittests label Jan 26, 2024
@stefanhaerter stefanhaerter added this to the OTOBO 11.0 milestone Jan 26, 2024
@stefanhaerter stefanhaerter self-assigned this Jan 26, 2024
stefanhaerter added a commit that referenced this issue Jan 26, 2024
@stefanhaerter
Issue #2889: Including waiting for autocomplete result to prevent tim…
7efdf5b 
…ing bug.
stefanhaerter added a commit that referenced this issue Jan 26, 2024
@stefanhaerter
Issue #2889: Included missing EditFieldMode key in reference field co…
6038879 
…nfigs.

Added value in expected result for single value text field in set.
@stefanhaerter stefanhaerter mentioned this issue Jan 26, 2024
Merged
svenoe pushed a commit that referenced this issue Jan 29, 2024
@stefanhaerter @svenoe
Issue #2889: Including waiting for autocomplete result to prevent tim…
b8a81e2 
…ing bug.
svenoe pushed a commit that referenced this issue Jan 29, 2024
@stefanhaerter @svenoe
Issue #2889: Included missing EditFieldMode key in reference field co…
597d1d3 
…nfigs.

Added value in expected result for single value text field in set.
@stefanhaerter
Copy link
Contributor Author

Two UT failures fixed with merging #2890

stefanhaerter added a commit that referenced this issue Jan 30, 2024
@stefanhaerter
Issue #2889: Re-enact rel-10_1 behavior for checkbox ValueSet with un…
d43e837 
…def value.
@stefanhaerter stefanhaerter mentioned this issue Jan 30, 2024
Closed
@bschmalhofer
Copy link
Contributor

Verified in latest run of the test suite:

Test Summary Report

/opt/otobo/scripts/test/Compile.t (Wstat: 0 Tests: 1741 Failed: 0)
TODO passed: 692, 819
/opt/otobo/scripts/test/DynamicField/Backend.t (Wstat: 512 (exited 2) Tests: 131 Failed: 2)
Failed tests: 107-108
Non-zero exit status: 2
/opt/otobo/scripts/test/DynamicField/EditFieldValueGet.t (Wstat: 3072 (exited 12) Tests: 196 Failed: 12)
Failed tests: 115-116, 119-120, 123-124, 146-147, 150-151
154-155
Non-zero exit status: 12
/opt/otobo/scripts/test/Selenium/Customer/DynamicFields/DynamicFieldDatabase.t (Wstat: 256 (exited 1) Tests: 40 Failed: 1)
Failed test: 40
Non-zero exit status: 1
/opt/otobo/scripts/test/Selenium/TestingMethods.t (Wstat: 0 Tests: 36 Failed: 0)
TODO passed: 21, 24, 28
Files=966, Tests=81436, 4029 wallclock secs (15.70 usr 2.05 sys + 1089.19 cusr 99.74 csys = 1206.68 CPU)

stefanhaerter added a commit that referenced this issue Jan 30, 2024
@stefanhaerter
Issue #2889: Fixed check for scalar value.
00d9c9f 
Bug was due to operator precedence.
stefanhaerter added a commit that referenced this issue Jan 30, 2024
@stefanhaerter
Issue #2889: Autocomplete selection mechanism needs two clicks.
60986e9
@stefanhaerter stefanhaerter mentioned this issue Jan 30, 2024
Merged
bschmalhofer pushed a commit that referenced this issue Jan 30, 2024
@stefanhaerter @bschmalhofer
Issue #2889: Fixed check for scalar value.
2cadcb8 
Bug was due to operator precedence.
bschmalhofer pushed a commit that referenced this issue Jan 30, 2024
@stefanhaerter @bschmalhofer
Issue #2889: Autocomplete selection mechanism needs two clicks.
8ed36fa
stefanhaerter added a commit that referenced this issue Jan 30, 2024
@stefanhaerter
Issue #2889: Let ValueStructureToDB return a value structure also in …
dac5af6 
…undef case.
@stefanhaerter stefanhaerter mentioned this issue Jan 30, 2024
Merged
svenoe pushed a commit that referenced this issue Jan 30, 2024
@stefanhaerter @svenoe
Issue #2889: Let ValueStructureToDB return a value structure also in …
e5783b0 
…undef case.
@bschmalhofer
Copy link
Contributor

Latest run of the test suite:

Test Summary Report

/opt/otobo/scripts/test/Compile.t (Wstat: 0 Tests: 1741 Failed: 0)
TODO passed: 692, 819
/opt/otobo/scripts/test/DynamicField/EditFieldValueGet.t (Wstat: 3072 (exited 12) Tests: 196 Failed: 12)
Failed tests: 115-116, 119-120, 123-124, 146-147, 150-151
154-155
Non-zero exit status: 12
/opt/otobo/scripts/test/Selenium/TestingMethods.t (Wstat: 0 Tests: 36 Failed: 0)
TODO passed: 21, 24, 28
Files=966, Tests=81578, 4560 wallclock secs (15.48 usr 1.91 sys + 1123.17 cusr 100.57 csys = 1241.13 CPU)
Result: FAIL

@stefanhaerter
Copy link
Contributor Author

Thank you very much for verifying the fixes 😊
I am happy that three of four are done so far, but the fourth is a bit tricky - it has to do with passing an unused value to dynamic fields date(time). I will need a bit of time to get on top of that.

stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2889: Avoided empty value problems by shifting index for check…
2c8492b 
…box values by one.
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2889: Avoided empty value problems by shifting index for check…
206e3fb 
…box values by one.
@stefanhaerter stefanhaerter mentioned this issue Feb 8, 2024
Merged
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2889: Enhanced comments.
ab34376
svenoe pushed a commit that referenced this issue Feb 8, 2024
@stefanhaerter @svenoe
Issue #2889: Avoided empty value problems by shifting index for check…
7f6c830 
…box values by one.
svenoe pushed a commit that referenced this issue Feb 8, 2024
@stefanhaerter @svenoe
Issue #2889: Enhanced comments.
fa41cb1
@stefanhaerter
Copy link
Contributor Author

stefanhaerter commented Feb 8, 2024 •
edited
Loading

The remaining test failure scripts/test/DynamicField/EditFieldValueGet.t should be fixed with merging PR #2947 - waiting for confirmation from @bschmalhofer =)

@bschmalhofer
Copy link
Contributor

Looks good:

Test Summary Report

/opt/otobo/scripts/test/Compile.t (Wstat: 0 Tests: 1745 Failed: 0)
TODO passed: 694, 822
/opt/otobo/scripts/test/Selenium/TestingMethods.t (Wstat: 0 Tests: 36 Failed: 0)
TODO passed: 21, 24, 28
Files=966, Tests=81596, 4333 wallclock secs (15.16 usr 2.12 sys + 1127.03 cusr 102.68 csys = 1246.99 CPU)
Result: PASS
ran tests for product OTOBO 11.0.x on host 078559ca0578 .

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanhaerter stefanhaerter

Labels
unittests Requests wrt unittests
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
2 participants
@bschmalhofer @stefanhaerter