UnitTests: Explicitily call $Self->DoneTesting() at the end of scripts

[bschmalhofer]

I suspect that there are some cases where test scripts exit before they reach the end of the script. This should be flagged as problems when the test are run with prove.
These cases can be caught by explicitly calling $Self->DoneTesting() explicitily at the end of the script.

Currently DoneTesting() is called in an the END block provided by Kernel::System::UnitiTest::RegisterDriver . But this is not sufficient as DoneTesting() is also called when the script exits early.

Just to muddy the water, there are 104 scripts that already call DoneTesting() explicitly. This makes no sense whatsoever, as in these case the plan is printed twice.

Just to be on the safe side the method Kernel::System::UnitTest::Driver::DoneTesting() should print nothing when the test script is run via Dev::UnitTest::Run. This can checked by inspecting the call stack.

The check for PlanWasSubmitted() can be removed, as the test script author is responsible for calling either $Self->Plan() or $Self->DoneTesting().

This plan required that destructors do not execute test functions. The only apparent case is Kernel::System::UnitTest::DESTROY(). In this sub the test functions can be replaced by calls to Note().

[bschmalhofer]

TODO:

• sanity check when run with 'prove*

• sanity check when run with 'Dev::UnitTest::Run', this is compare with the result from a run with OTOBO 10.0.x

[bschmalhofer]

Compared the output of two runs with Dev::UnitTest::Run. There are many diffs because things like dates and IDs are different. But altogether everything is looking good. Closing.