Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include package for custom translations into rel-11_0 #2948

Closed
stefanhaerter opened this issue Feb 8, 2024 · 6 comments
Closed

Include package for custom translations into rel-11_0 #2948

stefanhaerter opened this issue Feb 8, 2024 · 6 comments
Assignees
@stefanhaerter
Labels
enhancement New feature or request
Milestone
OTOBO 11.0.1

Comments

@stefanhaerter
Copy link
Contributor

No description provided.

@stefanhaerter stefanhaerter added the enhancement New feature or request label Feb 8, 2024
@stefanhaerter stefanhaerter added this to the OTOBO 11.0 milestone Feb 8, 2024
@stefanhaerter stefanhaerter self-assigned this Feb 8, 2024
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2948: Added custom translation functionality from package.
d452f5b
@stefanhaerter stefanhaerter mentioned this issue Feb 8, 2024
Merged
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2948: Added custom translation functionality from package.
f6ea217
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2948: Prevented comparison with undef value.
b816188
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2948: Renamed table attribute and param and restored previous …
69416a9 
…logic.
stefanhaerter added a commit that referenced this issue Feb 8, 2024
@stefanhaerter
Issue #2948: Added translation_item table to db upgrade to 11.0.
d014330
svenoe pushed a commit that referenced this issue Feb 8, 2024
@stefanhaerter @svenoe
Issue #2948: Added custom translation functionality from package.
b67d56e
svenoe pushed a commit that referenced this issue Feb 8, 2024
@stefanhaerter @svenoe
Issue #2948: Prevented comparison with undef value.
9482c46
svenoe pushed a commit that referenced this issue Feb 8, 2024
@stefanhaerter @svenoe
Issue #2948: Renamed table attribute and param and restored previous …
6ec07a3 
…logic.
svenoe pushed a commit that referenced this issue Feb 8, 2024
@stefanhaerter @svenoe
Issue #2948: Added translation_item table to db upgrade to 11.0.
f570552
@stefanhaerter
Copy link
Contributor Author

Closed with merging #2949

stefanhaerter added a commit that referenced this issue Feb 9, 2024
@stefanhaerter
Issue #2948: Include merged packages into uninstall module.
57d4fa8
svenoe pushed a commit that referenced this issue Feb 9, 2024
@stefanhaerter @svenoe
Issue #2948: Include merged packages into uninstall module.
619ce9c
@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 Mar 23, 2024
@bschmalhofer
Copy link
Contributor

Reopening: for consistencies sake the SysConfig settings for Import/Export of translations should be located in Kernel/Config/Files/XML/ImportExport.xml .

@bschmalhofer bschmalhofer reopened this Mar 23, 2024
@stefanhaerter
Copy link
Contributor Author

Are you already on this? Else I would try to have a look at it in the upcoming week.

@bschmalhofer
Copy link
Contributor

I'll leave that to you. But make the change only when it makes sense to you too. I simply figures that having all Import/Export related settings in one XML file is more intuitive.

stefanhaerter added a commit that referenced this issue Mar 27, 2024
@stefanhaerter
Issue #2948: Switched importexport settings for translations to dedic…
6cd7c3a 
…ated file.
@stefanhaerter stefanhaerter mentioned this issue Mar 27, 2024
Merged
@stefanhaerter
Copy link
Contributor Author

I have no strong opinion on this. When weighing having all translation options grouped together against having all importexport options in a dedicated file, I can see that the latter one is a bit more attractive. Made a PR: #3256.

bschmalhofer pushed a commit that referenced this issue Mar 27, 2024
@stefanhaerter @bschmalhofer
Issue #2948: Switched importexport settings for translations to dedic…
3de8321 
…ated file.
@bschmalhofer
Copy link
Contributor

The config has been cleaned up, thanks to @stefanhaerter . No problems were reported. Closing this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanhaerter stefanhaerter

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
2 participants
@bschmalhofer @stefanhaerter