Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method Kernel::Language::GetRecommendedCharset and the attribute ReturnCharset #3050

Closed
bschmalhofer opened this issue Feb 25, 2024 · 1 comment
Closed

Remove deprecated method Kernel::Language::GetRecommendedCharset and the attribute ReturnCharset #3050

bschmalhofer opened this issue Feb 25, 2024 · 1 comment

Comments

@bschmalhofer
Copy link
Contributor

The POD says:

=head2 GetRecommendedCharset()

DEPRECATED. Don't use this function any more, 'utf-8' is always the internal charset.

Returns the recommended charset for frontend (based on translation
file or utf-8).

    my $Charset = $LanguageObject->GetRecommendedCharset().

=cut

The method is only used to set the attribute ReturnCharset. This attribute seems to be unused and can be removed as well.
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: use and document the imported subrouting OTOBOTimeZoneGet()
52bd5b2
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: minor tidying
82edde5
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: eliminate the attribue ReturnCharset
1c57700 
as it was unused
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: remove the method GetRecommendedCharset()
bb380ee 
as it was unused and already deprecated.
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: use and document the imported subrouting OTOBOTimeZoneGet()
654e176
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: minor tidying
3575ff6
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: eliminate the attribue ReturnCharset
8f1d7b7 
as it was unused
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: remove the method GetRecommendedCharset()
a41f5af 
as it was unused and already deprecated.
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: use and document the imported subrouting OTOBOTimeZoneGet()
962a6e3
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: minor tidying
7fd7213
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: eliminate the attribue ReturnCharset
efeec0c 
as it was unused
bschmalhofer added a commit that referenced this issue Feb 26, 2024
@bschmalhofer
Issue #3050: remove the method GetRecommendedCharset()
1ecd8e9 
as it was unused and already deprecated.
@bschmalhofer
Copy link
Contributor Author

Done, skipping tests, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bschmalhofer