Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httponly attribute for the cookie 'OTOBBrowserHasCookie' #3092

Closed
bschmalhofer opened this issue Mar 1, 2024 · 2 comments
Closed

httponly attribute for the cookie 'OTOBBrowserHasCookie' #3092

bschmalhofer opened this issue Mar 1, 2024 · 2 comments
Assignees
@bschmalhofer
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

I noticed instances where the cookie with the name OTOBOBrowserHasCookie does not have the httponly attribute set. It is not obvious whether this is on purpose. It might be an oversight from mixing up the parameters HttpOnly and HTTPOnly. At least I did not find JavaScript code that accesses this cookie. So lets see what happens when the parameters HttpOnly are changed to HTTPOnly.
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Mar 1, 2024
@bschmalhofer bschmalhofer self-assigned this Mar 1, 2024
bschmalhofer added a commit that referenced this issue Mar 2, 2024
@bschmalhofer
Issue #3092: Parameter HttpOnly is actually HTTPOnly.
1e778cb 
This misspelled parameter name was used only for the OTOBOBrowserHasCookie cookie.
bschmalhofer added a commit that referenced this issue Mar 2, 2024
@bschmalhofer
Issue #3092: Parameter HttpOnly is actually HTTPOnly.
feaa9a3 
This misspelled parameter name was used only for the OTOBOBrowserHasCookie cookie.
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Mar 2, 2024 •
edited
Loading

TODO:

  • provide a default value in SetCookie()

bschmalhofer added a commit that referenced this issue Mar 3, 2024
@bschmalhofer
Issue #3092: change default of HTTPOnly to 1
bbf4572 
Do not pass unneeded 'HTTPOnly => 1' to SetCookie()
bschmalhofer added a commit that referenced this issue Mar 3, 2024
@bschmalhofer
Issue #3092: change default of HTTPOnly to 1
87197bb 
Do not pass unneeded 'HTTPOnly => 1' to SetCookie()
@bschmalhofer
Copy link
Contributor Author

httponly is now consistently set. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
None yet
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer