-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moo.pm and namespace::clean are not bundled, but are claimed to be bundled #33
Comments
Leaning towards 2; I will check this somewhen. |
Hi Bernhard, Moo and namespace is not used from OTOBO itself. It's a dependency from selenium, perhaps from other modules too. I´m not sure what's the right way, but I have no good feeling by adding the modules to Kernel/cpan-lib and add they to bin/otobo.CheckModules.pl as needed modules. For my opinion, bundled module do not say, it must bundled with OTOBO. It's possible that they bundled with other modules? Cause inside the list are a lot of modules not bundled with OTOBO, only with other modules. What do you think guys? Thanks very much for your help! Stefan |
Well Math::Random::Secure requires Moo and is used in ./Kernel/System/Main.pm. So this is core dependency. Which modules are listed in Kernel::System::Environment::PerlInfoGet() and are not available in Kernel/cpan-lib ? |
…dled This was a mistake in commit b539a662533 of the ((OTRS)) Community Edition
Issue #33: Don't claim that Moo and namespace::clean are bundled
PR submitted and applied. |
Kernel::System::Environment
claims that the package Moo is a bundled module . However there is no bundled Kernel/cpan-lib/Moo.pm. The same applies tonamespace::clean
and possibly other modules.There are two possible fixes:
Kernel::System::Environment
and add them to bin/otobo.CheckModules.pl as needed modulesI'm not sure what the preferred approach would be. One hunch is that adding the bundled modules to otobo.CheckModules is sensible in any case.
The text was updated successfully, but these errors were encountered: