Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moo.pm and namespace::clean are not bundled, but are claimed to be bundled #33

Closed
bschmalhofer opened this issue May 18, 2020 · 4 comments
Assignees
Milestone

Comments

@bschmalhofer
Copy link
Contributor

Kernel::System::Environment claims that the package Moo is a bundled module . However there is no bundled Kernel/cpan-lib/Moo.pm. The same applies to namespace::cleanand possibly other modules.

There are two possible fixes:

  1. Add Moo and namespace::clean to Kernel/cpan-lib
  2. Remove Moo and namespace::clean from Kernel::System::Environmentand add them to bin/otobo.CheckModules.pl as needed modules

I'm not sure what the preferred approach would be. One hunch is that adding the bundled modules to otobo.CheckModules is sensible in any case.

@svenoe
Copy link
Contributor

svenoe commented May 18, 2020

Leaning towards 2; I will check this somewhen.

@StefanRother-OTOBO
Copy link
Contributor

Hi Bernhard,

Moo and namespace is not used from OTOBO itself. It's a dependency from selenium, perhaps from other modules too. I´m not sure what's the right way, but I have no good feeling by adding the modules to Kernel/cpan-lib and add they to bin/otobo.CheckModules.pl as needed modules.

For my opinion, bundled module do not say, it must bundled with OTOBO. It's possible that they bundled with other modules? Cause inside the list are a lot of modules not bundled with OTOBO, only with other modules.

What do you think guys?

Thanks very much for your help!

Stefan

@bschmalhofer
Copy link
Contributor Author

Well Math::Random::Secure requires Moo and is used in ./Kernel/System/Main.pm. So this is core dependency.

Which modules are listed in Kernel::System::Environment::PerlInfoGet() and are not available in Kernel/cpan-lib ?

bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue Jun 3, 2020
…dled

This was a mistake in commit b539a662533 of the ((OTRS)) Community Edition
svenoe added a commit that referenced this issue Jun 3, 2020
Issue #33: Don't claim that Moo and namespace::clean are bundled
@bschmalhofer bschmalhofer changed the title Moo.pm not in Kernel/cpan-lib Moo.pm and namespace::clean are not bundled, but are claimed to be bundled Jun 3, 2020
@bschmalhofer
Copy link
Contributor Author

PR submitted and applied.

@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Jul 22, 2020
@bschmalhofer bschmalhofer self-assigned this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants