Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up EvaluateScriptFields event #3368

Closed
stefanhaerter opened this issue May 3, 2024 · 1 comment
Closed

Clean up EvaluateScriptFields event #3368

stefanhaerter opened this issue May 3, 2024 · 1 comment
Assignees
@stefanhaerter
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@stefanhaerter
Copy link
Contributor

The result of the call to _GetIncludedDynamicFields is used nowhere, so the entire function is useless in the module.

(Stumbled on this while working on the CMDB which has a similar event module)
@stefanhaerter stefanhaerter added the tidying Tidying of the code label May 3, 2024
@stefanhaerter stefanhaerter added this to the OTOBO 11.0 milestone May 3, 2024
@stefanhaerter stefanhaerter self-assigned this May 3, 2024
stefanhaerter added a commit that referenced this issue May 3, 2024
@stefanhaerter
Issue #3368: Clean up EvaluateScriptFields event.
5511ce5
@stefanhaerter stefanhaerter mentioned this issue May 3, 2024
Merged
svenoe pushed a commit that referenced this issue May 6, 2024
@stefanhaerter @svenoe
Issue #3368: Clean up EvaluateScriptFields event.
608a0e6
@stefanhaerter
Copy link
Contributor Author

Closed with merging #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanhaerter stefanhaerter

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@stefanhaerter