Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter 'FromCloud' from Kernel::System::Package::RepositoryAdd() #3408

Closed
3 tasks done
bschmalhofer opened this issue May 21, 2024 · 1 comment
Closed
3 tasks done

Remove unused parameter 'FromCloud' from Kernel::System::Package::RepositoryAdd() #3408

bschmalhofer opened this issue May 21, 2024 · 1 comment
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.2

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented May 21, 2024 •
edited
Loading

This documented parameter seems to be unused as it is only passed to PackageParse() which does not seem to use it.

TODO:

  • Remove FromCloud from RepositoryAdd()
  • Remove FromCloud from subroutines calling RepositoryAdd()
  • Check the remaining usage of FromCloud
@bschmalhofer bschmalhofer added the tidying Tidying of the code label May 21, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone May 21, 2024
@bschmalhofer bschmalhofer changed the title Remove unused parameter 'FromCloud' from Kernel::System::Package::RepositoryAdd Remove unused parameter 'FromCloud' from Kernel::System::Package::RepositoryAdd() May 21, 2024
bschmalhofer added a commit that referenced this issue May 24, 2024
@bschmalhofer
Issue #3408: a bit of tidying
8d52e79 
Assign an empty hashref as default for $RepositoryCloudList.
bschmalhofer added a commit that referenced this issue May 24, 2024
@bschmalhofer
Issue #3408: remove an unused variable
f3e2ad7
bschmalhofer added a commit that referenced this issue May 24, 2024
@bschmalhofer
Issue #3408: remove FromCloud from PackageInstall() and RepositoryAdd()
cc6125c
bschmalhofer added a commit that referenced this issue May 24, 2024
@bschmalhofer
Issue #3408: a bit of tidying
8746982 
Assign an empty hashref as default for $RepositoryCloudList.
bschmalhofer added a commit that referenced this issue May 24, 2024
@bschmalhofer
Issue #3408: remove an unused variable
1fcf900
bschmalhofer added a commit that referenced this issue May 24, 2024
@bschmalhofer
Issue #3408: remove FromCloud from PackageInstall() and RepositoryAdd()
d32202c
@bschmalhofer
Copy link
Contributor Author

Remove FromCloud from RepositoryAdd()and PackageInstall(). PR is applied. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.2 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.2
Development

No branches or pull requests
1 participant
@bschmalhofer