Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate the parameter 'Charset' to the method 'DocumentComplete' #3428

Closed
bschmalhofer opened this issue May 29, 2024 · 1 comment
Closed

Eliminate the parameter 'Charset' to the method 'DocumentComplete' #3428

bschmalhofer opened this issue May 29, 2024 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.3

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented May 29, 2024 •
edited
Loading

The only supported charset in the OTOBO fronend is utf-8. This value is already hard coded in Kernel::Output::HTML::Layout:_AddHeadersToResponseObject(). So let's remove this holdout from old times.

Also fix the test failures in scripts/test/HTMLUtils/DocumentComplete.t . See also #3100.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label May 29, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 11.0.3 milestone May 29, 2024
@bschmalhofer bschmalhofer self-assigned this May 29, 2024
bschmalhofer added a commit that referenced this issue May 29, 2024
@bschmalhofer
Issue #3428: convert test script to Test2::V0
4683470
bschmalhofer added a commit that referenced this issue May 29, 2024
@bschmalhofer
Issue #3428: Eliminate the parameter 'Charset'
4b36df7 
in the method DocumentComplete().
Add a test case with HTML markup, but no <html> tag
bschmalhofer added a commit that referenced this issue May 29, 2024
@bschmalhofer
Issue #3428: eliminate unused variables
00628b8 
or actually use the previously unused variables
bschmalhofer added a commit that referenced this issue May 29, 2024
@bschmalhofer
Issue #3428: convert test script to Test2::V0
45c0684
bschmalhofer added a commit that referenced this issue May 29, 2024
@bschmalhofer
Issue #3428: Eliminate the parameter 'Charset'
d0e908a 
in the method DocumentComplete().
Add a test case with HTML markup, but no <html> tag
bschmalhofer added a commit that referenced this issue May 29, 2024
@bschmalhofer
Issue #3428: eliminate unused variables
7cd482a 
or actually use the previously unused variables
@bschmalhofer
Copy link
Contributor Author

The test scripts looks fine. PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.3
Development

No branches or pull requests
1 participant
@bschmalhofer