Do not use legacy version of the ENV command

[bschmalhofer]

Doing a build with Docker version 27.0.2 I noticed warnings like:

2 warnings found (use --debug to expand):

• LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 25)
• LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 26)

These were due to the lines:

grep -n ENV otobo.elasticsearch.dockerfile
25:ENV LC_ALL C.UTF-8
26:ENV LANG C.UTF-8

Note that there are no = sign between key and value.

The explanation of the warnings is at https://docs.docker.com/reference/build-checks/legacy-key-value-format/ . The documentation of the ENV command confirms that. See https://docs.docker.com/reference/dockerfile/#env .

Note that e.g. otobo.nginx-kerberos.dockerfile already used the = signs.

ENV SPNEGO_AUTH_COMMIT_ID=v1.1.1
ENV SPNEGO_AUTH_COMMIT_ID_FILE=1.1.1

TODO:

• add the = sign to the ENV commands in rel-10_0, rel-10_1, rel-11_0, rel-11_1 branches

[bschmalhofer]

Done. The Docker image builds in the branches were fine. A run of the test suite in rel-10_0 was fine too. Closing this issue.