Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for Hint message in Email Outbound #3952

Closed
StefanAbel-OTOBO opened this issue Nov 26, 2024 · 3 comments
Closed

Missing translation for Hint message in Email Outbound #3952

StefanAbel-OTOBO opened this issue Nov 26, 2024 · 3 comments
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@StefanAbel-OTOBO
Copy link
Contributor

The translation for "Article subject will be empty if the subject contains only the ticket hook!" in Action=AgentTicketEmailOutbound is missing. The string is translated in translate.otobo.io , so I guess something like "translatable=1" is missing.

image

  1. Set User language to German
  2. Go to any ticket and open Communication > Email Outbound
  3. See hint message
@stefanhaerter
Copy link
Contributor

Confirmed.

@stefanhaerter
Copy link
Contributor

Explanation: The code fragment in question is:

# Inform a user that article subject will be empty if contains only the ticket hook (if nothing is modified).
$Output .= $LayoutObject->Notify(
Data => Translatable('Article subject will be empty if the subject contains only the ticket hook!'),
);

As param for Notify, Data is used - which, unlike e.g. Info, does not get translated in the notify template. So, we have a combination of not translated string (only marked as translatable) and not translated attribute. Fix is small, but it has to be decided how it is to be done.

svenoe pushed a commit that referenced this issue Jan 9, 2025
@stefanhaerter
Copy link
Contributor

Closed with merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants