Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSGI: test /hello and /otobo/dbviewer #444

Closed
bschmalhofer opened this issue Sep 15, 2020 · 4 comments
Closed

PSGI: test /hello and /otobo/dbviewer #444

bschmalhofer opened this issue Sep 15, 2020 · 4 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.0.6

Comments

@bschmalhofer
Copy link
Contributor

/dbviewer tends to bitrot. Add a test that runs only in the Docker use case.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Sep 15, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Sep 15, 2020
bschmalhofer added a commit that referenced this issue Sep 19, 2020
@bschmalhofer
Issue #444: explicitly specify 'use strict;'
5538476 
Even though strictness is already enforced by 'use v5.24.0'
bschmalhofer added a commit that referenced this issue Sep 19, 2020
@bschmalhofer
Issue #444: first stab at a test script for /dbviewer
706fac7
bschmalhofer added a commit that referenced this issue Sep 19, 2020
@bschmalhofer
Issue #444: actually check bin/Cron.sh
2e6e4d1
bschmalhofer added a commit that referenced this issue Sep 19, 2020
@bschmalhofer
Issue #444: make stub actually work
e3e2a2a 
But there are still TODOs for that test script.
bschmalhofer added a commit that referenced this issue Sep 20, 2020
@bschmalhofer
Issue #444: switch to using Test2::Tools::HTTP
7b64c26
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #444: restore the database after the test
cdb7ebb
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #444: add a couple of testcases and diagnostics
afbb12f 
But still get the OTOBO login URL for /hello
@bschmalhofer bschmalhofer self-assigned this Oct 2, 2020
@bschmalhofer
Copy link
Contributor Author

It might be less confusing when two test scripts are created: Hello.t and DbViewer.t.

@bschmalhofer bschmalhofer changed the title PSGI: add a test for the /dbviewer application PSGI: test /hello and /otobo/dbviewer Oct 5, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.0.6 Oct 23, 2020
@bschmalhofer
Copy link
Contributor Author

Improvements of the test suite can be done in the rel-10_0 branch. Do that and move the milestone to 10.0.6

bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: first stab at a test script for /dbviewer
fec6d65
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: make stub actually work
705ce24 
But there are still TODOs for that test script.
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: switch to using Test2::Tools::HTTP
ba6ec1f
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: restore the database after the test
493f104
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: add a couple of testcases and diagnostics
2483ce8 
But still get the OTOBO login URL for /hello
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: added 'use utf8'
32efeea
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: sync some minor changes from rel-10_1
cc6c2fd
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: add String::Dump as an optional module
651ca55
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: split up cpanm commands again
bacf945 
Because sometimes building the image fails.
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: cpanfile is not needed in the Docker image
669e662
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: construct the hello URL without '..'
682b1b9 
This seems to work.
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: actually check for 'permission denied'
c9416dd
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: add a TODO note, stating that the Login URL does not log in
5dc1268
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Issue #444: mark failing tests as TODO
706751b
bschmalhofer added a commit that referenced this issue Oct 23, 2020
@bschmalhofer
Merge pull request #571 from RotherOSS/issue-#444-dbviewer_hello_in_10_0
cecf70f 
Issue #444 dbviewer hello in 10 0
bschmalhofer added a commit that referenced this issue Oct 28, 2020
@bschmalhofer
Issue #444: RestoreDatabase apparently made the tests fail
b9ff37d 
Strange
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Oct 28, 2020 •
edited
Loading

The tests was not working because Kernel::System::UnitTest::Helper has RestoreDatabase enabled. This means that the test user was created in a transaction which is never committed. Thus the webserver can't see the added user.

bschmalhofer added a commit that referenced this issue Oct 28, 2020
@bschmalhofer
Issue #444: explain why RestoreDatabase does not work
98a8320
bschmalhofer added a commit that referenced this issue Oct 28, 2020
@bschmalhofer
Merge pull request #588 from RotherOSS/issue-#444-no_restore_database
52d35ef 
Issue #444 no restore database
@bschmalhofer
Copy link
Contributor Author

Tests are looking good. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.0.6
Development

No branches or pull requests
1 participant
@bschmalhofer