Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review code of the migration modules #500

Closed
bschmalhofer opened this issue Sep 30, 2020 · 2 comments
Closed

Review code of the migration modules #500

bschmalhofer opened this issue Sep 30, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.0.6

Comments

@bschmalhofer
Copy link
Contributor

@StefanRother-OTOBO asked me to take a look at the code in Kernel/System/MigrateFromOTRS .
Encountered problems or missing features should get their own issues.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Sep 30, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Sep 30, 2020
@bschmalhofer bschmalhofer self-assigned this Sep 30, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.0, OTOBO 10.1 Oct 2, 2020
@bschmalhofer
Copy link
Contributor Author

The subs _CheckOTOBOVersion() and _CheckOTRSVersion() are each declared in two different modules. Is the check performed twice?

bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: tidying, use v5.24, use utf8
f48ebf0
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: simplify checking of a return code
f56a7df
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: clean up not needed object dependencies
4cb8607
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: make the initial POD more consistent
0814abe
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: rename a variable in the POD
c1fdc3e
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: tidying
63468fa
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: restrict scope of some variables
4f8dabd
bschmalhofer added a commit that referenced this issue Oct 2, 2020
@bschmalhofer
Issue #500: $Type has been changed to $Class
ddf077a
@bschmalhofer bschmalhofer mentioned this issue Oct 3, 2020
Closed
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Merge pull request #538 from RotherOSS/issue-#500-code_review_1
5e29ea1 
Issue #500 code review 1
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: make the initial POD more consistent
cb77b19
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: rename a variable in the POD
58f4e4d
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: tidying
2fe9807
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: restrict scope of some variables
0e7f44e
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: $Type has been changed to $Class
a178d8b
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: tidying, use v5.24, use utf8
269ba42
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: simplify checking of a return code
9b54a62
bschmalhofer added a commit that referenced this issue Oct 12, 2020
@bschmalhofer
Issue #500: clean up not needed object dependencies
dbcc272
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.0.6 Oct 26, 2020
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: use namespace::autoclean. Don't use version.
473c417
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: add POD for the method Run()
f508514
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: tidying, mostly white space
43e4c40
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: tidying
28f9ebe 
Saner name for path to RELEASE.
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: Saner name for path to Kernel/Config.pm
90aee58
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: saner names of internal funcions
6fc69d9
bschmalhofer added a commit that referenced this issue Oct 26, 2020
@bschmalhofer
Issue #500: saner file and variable names
35ca695
bschmalhofer added a commit that referenced this issue Oct 27, 2020
@bschmalhofer
Merge pull request #579 from RotherOSS/issue-#500-review_migration_mo…
351c03f 
…dules

Issue #500 review migration modules
@bschmalhofer
Copy link
Contributor Author

Closing this issue. However further improvements to the migration modules are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.0.6
Development

No branches or pull requests
1 participant
@bschmalhofer