Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the interface for setting headers #566

Closed
bschmalhofer opened this issue Oct 23, 2020 · 5 comments
Closed

Use the interface for setting headers #566

bschmalhofer opened this issue Oct 23, 2020 · 5 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

This is a followup to #565. Actually use the interface for setting and getting headers. In the best case all of core OTOBO should be converted.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Oct 23, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Oct 23, 2020
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Nov 3, 2020 •
edited
Loading

TODO:

  • migrate the scripts in _bin/cgi-bin
  • migrate bin/psgi-bin/otobo.psgi
  • remove the UseResponseObject switch
  • adapt the SOAP interface
  • adapt the REST interface
  • adopt Kernel::System::Web::Exception
  • adapt the Kernel::Output::HTML::Layout::Print() method
  • adapt the Kernel::Output::HTML::Layout::Redirect() method
  • support for cookies
  • require Plack implicitly Plack::Response and HTTP::Headers::Fast
  • do not require CGI::Parse::PSGI, even it is part or the Plack distro
  • Support for header X-OTOBO-Login
  • check whether the OTOBO_RUNS_UNDER_PSGI switches are still necessary
  • deal with Kernel::Output::HTML::Layout::Print()
  • test

@bschmalhofer bschmalhofer mentioned this issue Nov 3, 2020
Closed
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: migrate the scripts in bin/cgi-bin
0bdfa6e
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: convert otobo.psgi
6fe2e8a
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: no need for switch UseResponseObject,
89dd445 
as this is now the only supported case
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: Switch SkipHTTPHeaders is no longer needed
19faef8
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: Fiddle with the CPAN dependencies
169c63e
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: fix spelling: alreadx => already
f99b3a7
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: actually emit a PSGI response in the fallback case
f4cb8ce
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: use the Kernel::System::Web::Response object in as_psgi()
5587eff
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: use the Kernel::System::Web::Response object in Print()
bdebc68
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: eliminate the special case on login.tt
e3bb81a 
Headers are set in Layout.pm
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: remove a HTTP header that was used for testing
3d74524
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: HTTPHeaders.tt is no longer needed
dc94e65
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: tidying
9150719
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: work on redirect handling
68aa9e7
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: PlackResponse is now the only supported param in the exce…
3109b48 
…ption object
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: tidying
3c6f8b4
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: add missing header creation
9f306f8
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: add cookie headers in _AddHeadersToResponseOBject()
ee4a1e5
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: tidying
ebd5619
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: pass response via an exception
b391e20 
Use the trick that seemed to have worked before.
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: tidying
c8199e6
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: tidying
676e6c6
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: try the exception workaround again
542f21f
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: eliminate CGI::Parse::PSGI
f00c37f
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: rename the methods HeaderAndContent() to Content()
4b685a1
bschmalhofer added a commit that referenced this issue Nov 3, 2020
@bschmalhofer
Issue #566: not yet used to how Plack::Response works
9508e84 
It's not a chaining interface.
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: eliminate $Self
8e8741f
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: tidying
0a4970e
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: load required modules, add missing '->new()'
83f37ba
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: Do not rely on $ENV{CONTENT_TYPE}
6dd2ee9
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: Do not rely on $ENV{HTTP_TRANSFER_ENCODING}
b93abbd
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: clean up remaining occurences of HeaderAndContent
46219e5
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: add a note that the cgi-bin scripts are broken
b5ebfcc
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: Generate content in the cgi-bin scripts
8c26772
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Issue #566: Generate content in the cgi-bin scripts
1a154a1
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Merge branch 'issue-#566-no_cgi_parse_psgi' of github.com:RotherOSS/o…
a2b3650 
…tobo into issue-#566-no_cgi_parse_psgi
bschmalhofer added a commit that referenced this issue Nov 4, 2020
@bschmalhofer
Merge branch 'rel-10_1' into issue-#566-no_cgi_parse_psgi
73425eb
bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Merge branch 'rel-10_1' into issue-#566-no_cgi_parse_psgi
96e0754
bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Issue #566: Tidying, work with subtests
93cc3f6
bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Issue #566: generate response with status 500 under PSGI
de2d7a8
bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Issue #566: add support for the PSGI case in HTTP::Test transport layer
45430f2
@bschmalhofer
Copy link
Contributor Author

Fixed remaining SOAP issues. Merging now into rel-10_0.

bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Merge pull request #623 from RotherOSS/issue-#566-no_cgi_parse_psgi
d4967e5 
Issue #566 no cgi parse psgi
bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Issue #566: update the SYNOPSIS
35e7168
bschmalhofer added a commit that referenced this issue Nov 5, 2020
@bschmalhofer
Merge pull request #624 from RotherOSS/issue-#566-no_cgi_parse_psgi
eaec7d9 
Issue #566: update the SYNOPSIS
@bschmalhofer
Copy link
Contributor Author

Kernel::Output::HTML::Layout::Print() still prints to STDOUT. This should be adapted.

bschmalhofer added a commit that referenced this issue Nov 9, 2020
@bschmalhofer
Issue #566: tidying
19083a1
bschmalhofer added a commit that referenced this issue Nov 9, 2020
@bschmalhofer
Issue #566: do not call the method Print() before the complete conten…
830f2d3 
…t was collected
bschmalhofer added a commit that referenced this issue Nov 9, 2020
@bschmalhofer
Issue #566: more tidying
c623950
@bschmalhofer
Copy link
Contributor Author

Print() was called early when generting some lists. This makes sense for getting a quick response, but does not fit trivially into the PSGI environment. If early response is needed, then it should be handled in a dedicated issue.

bschmalhofer added a commit that referenced this issue Nov 9, 2020
@bschmalhofer
Merge pull request #626 from RotherOSS/issue-#566-layout_print
f0759ee 
Issue #566 layout print
@bschmalhofer
Copy link
Contributor Author

There are no known problems. Closing this issue.

@bschmalhofer bschmalhofer self-assigned this Jan 19, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer