Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DBIx::Connector in the non-PSGI case #577

Closed
bschmalhofer opened this issue Oct 26, 2020 · 2 comments
Closed

Use DBIx::Connector in the non-PSGI case #577

bschmalhofer opened this issue Oct 26, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Oct 26, 2020 •
edited
Loading

Reducing the number of variants is a good thing.
But it has to be pondered whether DBIx::Connector should really be used for console commands and daemon tasks.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Oct 26, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Oct 26, 2020
@bschmalhofer
Copy link
Contributor Author

Discussed this with @svenoe . There is no good reason to use DBIx::Connector only when running under a webserver. Thus the code can be simplified and DBIx::Connector can be used in all cases.

@bschmalhofer bschmalhofer self-assigned this Nov 11, 2021
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Nov 11, 2021
bschmalhofer added a commit that referenced this issue Nov 11, 2021
@bschmalhofer
Issue #577: CGI::PSGI and DBIx::Connector are required,
340c463 
thus they shouldn't be listed under the section for the feature 'gazelle'.
bschmalhofer added a commit that referenced this issue Nov 11, 2021
@bschmalhofer
Issue #577: always use DBIx::Connector
7dc70ee 
no special case when not running in a web environment
bschmalhofer added a commit that referenced this issue Nov 11, 2021
@bschmalhofer
Issue #577: mention where GATEWAY_INTERFACE is used
5ae2ae1
bschmalhofer added a commit that referenced this issue Nov 11, 2021
@bschmalhofer
Issue #577: standardize code comments about GATEWAY_INTERFACE
4326ed8
bschmalhofer added a commit that referenced this issue Nov 11, 2021
@bschmalhofer
Issue #577: GATEWAY_INTERFACE is also used in Kernel::Config::Defaults
8f28110
@bschmalhofer
Copy link
Contributor Author

The test suite looked fine. Closing this issue.

bschmalhofer added a commit that referenced this issue Nov 11, 2021
@bschmalhofer
Merge pull request #1399 from RotherOSS/issue-#577-dbix_connector
77362d5 
Issue #577 dbix connector
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer