Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove method Kernel::Output::HTML::Layout::_DisableBannerCheck() #605

Closed
bschmalhofer opened this issue Nov 2, 2020 · 1 comment
Closed

Remove method Kernel::Output::HTML::Layout::_DisableBannerCheck() #605

bschmalhofer opened this issue Nov 2, 2020 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.0.6

Comments

@bschmalhofer
Copy link
Contributor

The method tries to remove the X-Powered-By HTTP header when Secure::DisableBanner is active. For that it uses the pattern
^ X-Powered-By: .+? Open \s Ticket \s Request \s System \s \(http .+? \)$ \n
However the actually generated header is something like X-Powered-By: OTOBO 10.1.x (https://www.otobo.de/)` which does not match the above regexp.
The method is not needed anyways, because Secure::DisableBanner is already considered when creating the HTTP headers.
Therefore the method can safely be removed.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Nov 2, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.6 milestone Nov 2, 2020
@bschmalhofer bschmalhofer self-assigned this Nov 2, 2020
bschmalhofer added a commit that referenced this issue Nov 2, 2020
@bschmalhofer
Issue #605: tidying
9e144a2
bschmalhofer added a commit that referenced this issue Nov 2, 2020
@bschmalhofer
Issue #605: remove _DisableBannerCheck()
5ab45e6
bschmalhofer added a commit that referenced this issue Nov 2, 2020
@bschmalhofer
Issue #605: grab some minor changes from the rel-10_1 branch
748b5f6 
Trying to keep the diffs small.
bschmalhofer added a commit that referenced this issue Nov 2, 2020
@bschmalhofer
Merge pull request #607 from RotherOSS/issue-#605-disable_banner_check
3b33358 
Issue #605 disable banner check
@bschmalhofer
Copy link
Contributor Author

Closing this issue, being confident that nothing is broken.

bschmalhofer added a commit that referenced this issue Nov 2, 2020
@bschmalhofer
Issue #605: tidying
febe666
bschmalhofer added a commit that referenced this issue Nov 2, 2020
@bschmalhofer
Issue #605: remove _DisableBannerCheck()
3824710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.0.6
Development

No branches or pull requests
1 participant
@bschmalhofer