Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: unneeded interaction with %ENV #622

Closed
1 task done
bschmalhofer opened this issue Nov 5, 2020 · 2 comments
Closed
1 task done

Testing: unneeded interaction with %ENV #622

bschmalhofer opened this issue Nov 5, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Nov 5, 2020 •
edited
Loading

Some test scripts are messing with the environment. This is sensible in some cases. In other cases my suspicion is that this is not needed any more.

TODO:

  • Check the files reported by: grep -r ENV scripts/test/ | grep -v OTOBO_RUNS_UNDER_DOCKER | grep -v TZ | grep -v SKIP_NUTSANDBOLTS_TEST | grep -v COMP_LINE
@bschmalhofer bschmalhofer added the enhancement New feature or request label Nov 5, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Nov 5, 2020
bschmalhofer added a commit that referenced this issue Nov 10, 2020
@bschmalhofer
Issue #622: remove empty lines around $Self->DoneTesting()
83aa529
bschmalhofer added a commit that referenced this issue Nov 10, 2020
@bschmalhofer
Issue #622: add some code comments, explaining about %ENV
f5bf18b
bschmalhofer added a commit that referenced this issue Nov 10, 2020
@bschmalhofer
Issue #622: no need to create $Request in the test script
50d2a99
bschmalhofer added a commit that referenced this issue Nov 10, 2020
@bschmalhofer
Issue #622: no need to set up a CGI environment in test script
37716d8
@bschmalhofer
Copy link
Contributor Author

Setting up a CGI environment was useless in only a single test script, that is PossibleValuesGet.t.
I added some code comments in the other scripts for explaining why %ENV is fiddled with.

bschmalhofer added a commit that referenced this issue Nov 10, 2020
@bschmalhofer
Merge pull request #631 from RotherOSS/issue-#622_env_hash
4d52c3a 
Issue #622 env hash
@bschmalhofer
Copy link
Contributor Author

PR is merged, closing the issue.

@bschmalhofer bschmalhofer self-assigned this Nov 28, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer