Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expressions for dynamic fields in CustomerInterface. #625

Closed
svenoe opened this issue Nov 6, 2020 · 5 comments · Fixed by #1233
Closed

Fix regular expressions for dynamic fields in CustomerInterface. #625

svenoe opened this issue Nov 6, 2020 · 5 comments · Fixed by #1233
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@svenoe
Copy link
Contributor

svenoe commented Nov 6, 2020

Good Morning,

i have found another error, if a RexEx is entered in a dynamic field of type text, it does not appear in the customer interface.

Thanks!

Stefan

Originally posted by @StefanRother-OTOBO in #590 (comment)

@svenoe svenoe added the bug Something isn't working as intended label Nov 6, 2020
@svenoe svenoe self-assigned this Nov 6, 2020
@svenoe svenoe added this to the OTOBO 10.0.6 milestone Nov 6, 2020
svenoe pushed a commit that referenced this issue Nov 6, 2020
@svenoe
Copy link
Contributor Author

svenoe commented Nov 6, 2020

Commit 63de46d is labeled wrong, belongs to Issue #590 .

@svenoe svenoe modified the milestones: OTOBO 10.0.6, OTOBO 10.0.7 Nov 12, 2020
@svenoe svenoe modified the milestones: OTOBO 10.0.7, OTOBO 10.0.8 Jan 15, 2021
@svenoe svenoe modified the milestones: OTOBO 10.0.8, OTOBO 10.0.9 Feb 8, 2021
@svenoe svenoe modified the milestones: OTOBO 10.0.9, OTOBO 10.0 Feb 18, 2021
@stefanhaerter
Copy link
Contributor

What exactly is the wanted behavior in this case?

Additionally, the label for a text field with regular expression in the customer interface is located on the right, unlike other fields. Is this correct?

@svenoe
Copy link
Contributor Author

svenoe commented Sep 6, 2021

Basically the error messages are not working properly in the customer interface atm. This issue is mostly a css/ui-problem. (Compare wrongly filled fields in agent and customer interface for the functionality. I have no plan for the design, but probably a simple, small, red text message under the field.)

And yes, text fields are not properly designed yet, either.

@stefanhaerter
Copy link
Contributor

Investigating the issue, I recommend to fix this within Issue #1132. Noteworthy details here are:

  • different behaviour between agent and customer interface
  • adding the error message behind the label
  • handling the error message text in template files

Moving the milestone to 10.1.

@stefanhaerter
Copy link
Contributor

Idea: Displaying ServerError Tooltip as label and not as div in CustomerInterface.
Problem: The input field may already have a label.

stefanhaerter added a commit that referenced this issue Feb 15, 2022
stefanhaerter added a commit that referenced this issue Feb 22, 2022
stefanhaerter added a commit that referenced this issue Feb 22, 2022
stefanhaerter added a commit that referenced this issue Feb 22, 2022
svenoe pushed a commit that referenced this issue Feb 22, 2022
svenoe pushed a commit that referenced this issue Feb 22, 2022
svenoe pushed a commit that referenced this issue Feb 22, 2022
svenoe pushed a commit that referenced this issue Feb 22, 2022
svenoe pushed a commit that referenced this issue Feb 22, 2022
@svenoe svenoe closed this as completed Feb 22, 2022
@svenoe svenoe modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Feb 22, 2022
svenoe pushed a commit that referenced this issue Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants