Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Selenium test use skin ivory, but that skin does not exist #678

Closed
bschmalhofer opened this issue Dec 25, 2020 · 9 comments
Closed
Labels
bug Something isn't working as intended selenium Related to fixing or improving testing with Selenium
Milestone

Comments

@bschmalhofer
Copy link
Contributor

See the failing test in scripts/test/Selenium/SysConfig/AgentSetting.t .
Providing a sample skin should resolve the issue.

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Dec 25, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.7 milestone Dec 25, 2020
@bschmalhofer
Copy link
Contributor Author

Another instance is the skin highcontrast which is used in scripts/test/Selenium/Agent/AgentTicketZoom.t .

@bschmalhofer
Copy link
Contributor Author

@StefanRother-OTOBO : Why is there only the default skin in var/httpd/htdocs/skins/Agent and in var/httpd/htdocs/skins/Customer ? Especially a highcontrast skin would be good to have.

@svenoe
Copy link
Contributor

svenoe commented Jan 4, 2021

Hi Bernhard,
with our changes to the agent interface, we disabled non standard skins. But you are right that enabling them at one point would be good.
Sven

@bschmalhofer
Copy link
Contributor Author

See also #682.

@svenoe svenoe modified the milestones: OTOBO 10.0.7, OTOBO 10.0.8 Jan 15, 2021
@svenoe
Copy link
Contributor

svenoe commented Jan 15, 2021

Is this test just about testing this skin? Then we could just skip it for the moment.

@wollmers
Copy link
Contributor

@svenoe It just tests, that the skin selection/switch to another skin works. A manual test works. So no big risk to skip it at the moment.

Improvement could be to skip, if there is only one (the default) skin.

@svenoe
Copy link
Contributor

svenoe commented Jan 15, 2021

Thanks Helmut - yes, ok, at least for the moment this is unimportant then and could be skipped, in my opinion.

bschmalhofer added a commit that referenced this issue Jan 16, 2021
Becaus skin 'ivory' does not exist. See #678.
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jan 16, 2021

For #682 some test cases were set to TODO because of this issue.

Test cases in the following scrips must be un-TODOed when this issue is resolved:

  • scripts/test/Selenium/Agent/AgentPreferences.t
  • scripts/test/Selenium/Agent/AgentTickerZoom.t
  • scripts/test/Selenium/SysConfig/AgentSetting.t

@bschmalhofer bschmalhofer added the selenium Related to fixing or improving testing with Selenium label Jan 18, 2021
@bschmalhofer
Copy link
Contributor Author

There are no immediate plans to add skin. The existing test the depend on a skin are TODOed. Let's leave them in place, in case that skins will be added in future. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended selenium Related to fixing or improving testing with Selenium
Projects
None yet
Development

No branches or pull requests

3 participants