Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify status of OTOBOCommunity #681

Closed
bschmalhofer opened this issue Dec 27, 2020 · 9 comments
Closed

Clarify status of OTOBOCommunity #681

bschmalhofer opened this issue Dec 27, 2020 · 9 comments
Assignees
Labels
tidying Tidying of the code
Milestone

Comments

@bschmalhofer
Copy link
Contributor

In the OTOBO source code and in the test scripts there are some references to OTOBOCommunity. In the original OTRS 6 Community Edition this was OTRSBusiness.
What is the status of OTOBOCommunity? Can all references be removed?

@StefanRother-OTOBO
Copy link
Contributor

StefanRother-OTOBO commented Dec 27, 2020

Hi Bernhard,

OTOBO has no Community or Business version, I think this is simply a result of the search and replace from the fork.
I'm not sure if it's possible to remove all old OTRSBusiness stuff. Perhaps have a look which test is needed?

I would like to leave the code itself, because I'd like to implement some more business stuff.

@svenoe, what do you think?

Thanks,

Stefan

@svenoe
Copy link
Contributor

svenoe commented Jan 4, 2021

Yes, this is the renaming of our scripts, quite probably everywhere it occurs. In our first migrations I searched for every instance of OTRS Business and threw out a lot of it, so a lot of what's left should be stuff which I either found interesting, or where I was unsure, and in the end every occurrence should be investigated separately.

We should tidy this up somewhen, but probably after 10.1 is done and we are thinking more about 11.0 features, I guess...

@svenoe svenoe added tidying Tidying of the code and removed question Further information is requested labels Jan 4, 2021
@svenoe svenoe modified the milestones: OTOBO 10.1, OTOBO 11.0 Jan 4, 2021
@bschmalhofer
Copy link
Contributor Author

@StefanRother-OTOBO As far as I see, the directory Kernel/Config/Files/User is used in Kernel/System/Web/InterfaceAgent.pm and in Kernel/System/SysConfig/Base/OTOBOCommunity.pm . So is this, whatever it is, still supported in OTOBO ? Or is it an OTRS Business feature? In the latter case, I would remove it for the 10.1 release.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Mar 24, 2021

@StefanRother-OTOBO clarified that user configs in Kernel/Config/Files/User is a rarely used, but potentially useful, feature. It won't be removed. Still, I think that moving the code into a module like Kernel/System/SysConfig/UserSpecificSettings.pm would be a good idea.
Note that support for user specific config is not implemented in Kernel::Config but in Kernel::System::Web::InterfaceAgent.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Aug 15, 2021

References to OTOBOSTORM and OTOBOCONTROL can be removed as well.

bschmalhofer added a commit that referenced this issue Aug 15, 2021
Remove mention of OTOBOSTROM and OTOBOCONTROL, as OTOBO does not have
a STORM or CONTROL variant.
bschmalhofer added a commit that referenced this issue Aug 15, 2021
Issue #681: remove a couple of mentions of OTOBOCommunity
@bschmalhofer
Copy link
Contributor Author

Removed a couple of places where OTOBOCommunity is mentioned. The remaining mention could be removed too, but this is not really required.
Still nice to have is splitting up Kernel/System/SysConfig/Base/OTOBOCommunity.pm into Kernel/System/SysConfig/Base/SettingHistory.pm and Kernel/System/SysConfig/Base/UserSettings.pm .

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 10.1 Aug 15, 2021
bschmalhofer added a commit that referenced this issue Aug 16, 2021
…ttings.pm

The new files still have to be adapted.
bschmalhofer added a commit that referenced this issue Aug 16, 2021
Clean up the duplicated subs. Update POD. Update ObjectDependencies.
bschmalhofer added a commit that referenced this issue Aug 16, 2021
@bschmalhofer
Copy link
Contributor Author

OTOBOCommunity.pm is broken up now. The test suite looks fine. Closing this issue.

@bschmalhofer
Copy link
Contributor Author

Found another occurence:

grep -r 'OTOBO Community' . | more
./Kernel/Output/HTML/Templates/Standard/AdminDynamicField.tt:

[% Translate("New OTOBO Community Fields") | html %]

@bschmalhofer bschmalhofer added this to the OTOBO 10.1.1 milestone Nov 28, 2021
@bschmalhofer
Copy link
Contributor Author

There are still a few instances of OTOBOCommunity in the SysConfig.

egrep -rl '00.{1}-OTOBOCommunity'
Kernel/Output/HTML/NavBar/AdminContactWD.pm
Kernel/Config/Files/ZZZAAuto.pm
Kernel/Config/Files/XML/Framework.xml
Kernel/Config/Files/XML/OTOBODynamicFields.xml
Kernel/Modules/AgentTicketZoom.pm

These could be cleaned up in rel-11_0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidying Tidying of the code
Projects
None yet
Development

No branches or pull requests

3 participants