Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable customer preferences #693

Closed
mo-azfar opened this issue Dec 30, 2020 · 6 comments
Closed

Enable customer preferences #693

mo-azfar opened this issue Dec 30, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@mo-azfar
Copy link

Accessing to customer.pl?Action=CustomerPreferences return inconvenience display

Capture

@svenoe svenoe self-assigned this Jan 4, 2021
@svenoe svenoe added the enhancement New feature or request label Jan 4, 2021
@svenoe
Copy link
Contributor

svenoe commented Jan 4, 2021

Hi Mohd,

this screen is not implemented, yet (there shouldn't be a link to it, we seemingly forgot to disable direct access, though). Eventually it would be good to make this available, though, I guess. Thanks for pointing it out,

Sven

@svenoe svenoe changed the title CustomerPreferences css layout Enable customer preferences Jan 4, 2021
@mo-azfar
Copy link
Author

mo-azfar commented Jan 8, 2021

Hi Mohd,

this screen is not implemented, yet (there shouldn't be a link to it, we seemingly forgot to disable direct access, though). Eventually it would be good to make this available, though, I guess. Thanks for pointing it out,

Sven

Hi Sven,

Thanks for the update..
Any way we can just access at least access only 'password update screen' and '2 FA secret key screen' at the moment?

As OTRS 6 CE is no longer pushing security update, my team are looking to move over to OTOBO.

@svenoe
Copy link
Contributor

svenoe commented Jan 8, 2021

Hi Mohd,

not without some development, I fear. We will definitely reimplement this, I cannot make promises when it will happen, exactly, though. If you need it straight away, you can send us a message to hello@otobo.de to hire us, or if you have the capability, enhance OTOBO yourself (please open a pull request, if you do :) ).

Best regards, Sven

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Mar 28, 2021

When CustomerPreferences is enabled, then the following test scripts should be reactivated too:

  • scripts/test/Selenium/Customer/CustomerPreferences.t
  • scripts/test/Selenium/Output/Preferences/Customer/Language.t
  • scripts/test/Selenium/Output/Preferences/Customer/Password.t
  • scripts/test/Selenium/Output/Preferences/Customer/TimeZone.t

bschmalhofer added a commit that referenced this issue Apr 8, 2021
Also: use Test2::V0, eradicate $Self
bschmalhofer added a commit that referenced this issue Apr 9, 2021
This is fine, as customer preferences are not yet active. See #693.
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
…[type=field] should be improved somewhen.
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe pushed a commit that referenced this issue Apr 13, 2021
svenoe added a commit that referenced this issue Apr 13, 2021
@svenoe
Copy link
Contributor

svenoe commented Apr 13, 2021

Should be fixed. Standard settings still need some overhaul, but that is true for the agent interface, too and will be done in a separate issue.

@svenoe svenoe closed this as completed Apr 13, 2021
bschmalhofer added a commit that referenced this issue Apr 14, 2021
Avoid some possible exceptions from find_element().
bschmalhofer added a commit that referenced this issue Apr 14, 2021
Rename $ScriptAlias to $LoginPage, because seems more sensible
@bschmalhofer
Copy link
Contributor

bschmalhofer commented Apr 14, 2021

The is_displayed() test of CustomerPreferences.t can stay at TODO for now. The elements are enabled, just not visible on the screen.
The other TODO tests for #693 habe been un-TODOed.

bschmalhofer added a commit that referenced this issue Apr 14, 2021
bschmalhofer added a commit that referenced this issue Apr 14, 2021
bschmalhofer added a commit that referenced this issue Apr 14, 2021
bschmalhofer added a commit that referenced this issue Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants