Decide about Kernel::Output::HTML::Notification::AgentSessionLimit

[bschmalhofer]

As of OTOBO 10.0.7 the notification Kernel::Output::HTML::Notification::AgentSessionLimit is only a stub. In OTRS this notification is presented when the session limit is approached. As OTOBO has no session limit I would surmise that this notification is not needed in OTOBO. @StefanRother-OTOBO: Is that correct?

When no session limit checks are needed, then it should be decided whether this notification should be kept for just in case, or removed completely.

TODO:

• decide and act accordingly
• fix or remove the TODO test in scripts/test/Selenium/Agent/Login.t

[svenoe]

I think we can remove it. In the end the code is not lost as it's in git. There is no need for keeping it "just in case".

[bschmalhofer]

Ah, I just found out that there still is a session limit in OTOBO. See Framework.xml:

    <Setting Name="AgentSessionLimit" Required="0" Valid="1">
        <Description Translatable="1">Sets the maximum number of active agents within the timespan defined in SessionMaxIdleTime.</Description>
        <Navigation>Core::Session</Navigation>
        <Value>
            <Item ValueType="String" ValueRegex="^[0-9]{1,8}$">100</Item>
        </Value>
    </Setting>

The relevant check is in Kernel/System/AuthSession.pm . Now tthis is a bit inconsistent. When there is a session limit, then a notification that the limit is approaching does make sense. Or should the agent session limit feature be also removed from OTOBO?

[bschmalhofer]

Discussed this with @svenoe and @StefanRother-OTOBO . The conclusion is:

• The agent session check will be kept as currently set up, currently the limit is 100 sessions
• The notification that the limit is approaching will reactivated,

[bschmalhofer]

Started to reintegrate the config, tests and implementation of the notification module.

[bschmalhofer]

Tests look fine. Closing this issue.