Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Kernel::System::Web::Request into a immutable class #825

Closed
bschmalhofer opened this issue Feb 27, 2021 · 2 comments
Closed

Turn Kernel::System::Web::Request into a immutable class #825

bschmalhofer opened this issue Feb 27, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
invalid The report was either incorrect, or it describes the correct behavior. question Further information is requested
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

Kernel::System::Web::Request contains the request data for the current HTTP Request. For some measures of intuitiveness, it is not intuitive that instances of this class are modified during the request. At least the methods SetCookie and SaveFormDraft provide means to modify the ParamObject.

I propose to refactor the code so that the ParamObject becomes immutable.
@bschmalhofer bschmalhofer added the question Further information is requested label Feb 27, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Feb 27, 2021
@bschmalhofer bschmalhofer mentioned this issue Jun 11, 2021
Closed
@bschmalhofer
Copy link
Contributor Author

Checking again, SetCookie() does not modify the object. LoadFormDraft() does set params in the query object. SaveFormDraft() does not modify the ParamObject, but the FormDraftObject.

@bschmalhofer bschmalhofer self-assigned this Aug 22, 2021
@bschmalhofer bschmalhofer added the invalid The report was either incorrect, or it describes the correct behavior. label Aug 22, 2021
@bschmalhofer
Copy link
Contributor Author

The LoadFormDraft()use case looks like a legitimate use case. Therfore rejecting this issue, no need to change anything.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
invalid The report was either incorrect, or it describes the correct behavior. question Further information is requested
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer