Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the code in rel-10_1 branch to work with CodePolicy #1031

Closed
bschmalhofer opened this issue May 27, 2021 · 2 comments
Closed

Adjust the code in rel-10_1 branch to work with CodePolicy #1031

bschmalhofer opened this issue May 27, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

Checked the Codepolicy for the rel-10_0 and the issue-#1000-zzz_reload branches. Looks good. Closing this issue and open one for the rel-10_1 branch.

Originally posted by @bschmalhofer in #760 (comment)
@bschmalhofer bschmalhofer self-assigned this May 27, 2021
@bschmalhofer bschmalhofer added the tidying Tidying of the code label May 27, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone May 27, 2021
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Issue #1031: for batch of changes for CodePolicy
57ccfaa
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Issue #1031: second batch of changes for CodePolicy
bd1a49e
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Issue #1031: accept suggestions from Perl::Tidy
2c01f9d
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Issue #1031: the scripts in cgi-bin may meddle with %ENV
2ea8d2b 
Assuming that mod_perl does the right thing.
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Merge pull request #1034 from RotherOSS/issue-#1031-codepolicy_in_rel…
879f866 
…_10_1

Issue #1031 codepolicy in rel 10 1
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Issue #1031: do not add Kernel::System::Web::Request to the ObjectDep…
f887abd 
…endencies

Because this lead to errors. The ObjectManager is strange.
bschmalhofer added a commit that referenced this issue May 27, 2021
@bschmalhofer
Merge pull request #1036 from RotherOSS/issue-#1031-rollback_object_d…
cf00dbc 
…ependencies

Issue #1031: do not add Kernel::System::Web::Request to the ObjectDep…
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented May 27, 2021 •
edited
Loading

For some reason, adding Kernel::System::Web::Request to the ObjectDependencies broke the test suite. Reverted that change.
TODO;

  • decide what to do about the complaints from OTOBO::Perl::ObjectDependencies

bschmalhofer added a commit that referenced this issue Jun 11, 2021
@bschmalhofer
Issue #1031: add Kernel::System::Web::Request to ObjectDependencies
9702d06
bschmalhofer added a commit that referenced this issue Jun 11, 2021
@bschmalhofer
Issue #1031: allow usage of 'open'
e04104e
bschmalhofer added a commit that referenced this issue Jun 11, 2021
@bschmalhofer
Issue #1031: accept suggestions from Perl::Tidy
7b3d415
bschmalhofer added a commit that referenced this issue Jun 11, 2021
@bschmalhofer
Merge pull request #1080 from RotherOSS/issue-#1031-code_policy
081482c 
Issue #1031 code policy
@bschmalhofer
Copy link
Contributor Author

Only the complaints related to #825 are reported now. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer