Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel::System::UnitTest::Selenium should extend Test::Selenium::Remote::Driver #868

Closed
bschmalhofer opened this issue Mar 16, 2021 · 2 comments
Closed

Kernel::System::UnitTest::Selenium should extend Test::Selenium::Remote::Driver #868

bschmalhofer opened this issue Mar 16, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
selenium Related to fixing or improving testing with Selenium
Milestone
OTOBO 10.0.10

Comments

@bschmalhofer
Copy link
Contributor

Currently Kernel::System::UnitTest::Selenium extends Selenium::Remote::Driver. Test::Selenium::Remote::Driver extends Selenium::Remote::Driver and adds testing methods. Thus switching the base class gives nifty testing methods to Kernel::System::UnitTest::Selenium for free.
No additional dependencies have to be added. My hunch is that the setup of the WebElement class should work out of the box.
@bschmalhofer bschmalhofer added the selenium Related to fixing or improving testing with Selenium label Mar 16, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.10 milestone Mar 16, 2021
@bschmalhofer bschmalhofer self-assigned this Mar 16, 2021
@bschmalhofer
Copy link
Contributor Author

Not as easy as expected. There was an error stating that the remote driver does not support javascript. Strange.

bschmalhofer added a commit that referenced this issue Mar 16, 2021
@bschmalhofer
Issue #868: change the extends declaration
0dd8ccb
bschmalhofer added a commit that referenced this issue Mar 16, 2021
@bschmalhofer
Issue #868: require Selenium::Remote::Driver 1.41
6dacf68 
No need to chase old bugs.
bschmalhofer added a commit that referenced this issue Mar 16, 2021
@bschmalhofer
Issue #868: explicitly turn on javascript
18e2f0d 
As Test::Selenium::Remote::Driver has a different default than Selenium::Remote::Driver.
bschmalhofer added a commit that referenced this issue Mar 16, 2021
@bschmalhofer
Issue #868: newest version of Selenium::Remote::Driver is 1.40
3431448
bschmalhofer added a commit that referenced this issue Mar 17, 2021
@bschmalhofer
Merge pull request #872 from RotherOSS/issue-#868-Test_Selenium_Remot…
d9d92c6 
…e_Driver

Issue #868 test selenium remote driver
@bschmalhofer
Copy link
Contributor Author

Tests look fine after setting the option javascript explicitly to 1. Closing this issue. See also teodesian/Selenium-Remote-Driver#466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
selenium Related to fixing or improving testing with Selenium
Projects
None yet
Milestone
OTOBO 10.0.10
Development

No branches or pull requests
1 participant
@bschmalhofer