Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont include dot-files in the Docker images #951

Closed
bschmalhofer opened this issue Apr 18, 2021 · 2 comments
Closed

Dont include dot-files in the Docker images #951

bschmalhofer opened this issue Apr 18, 2021 · 2 comments
Assignees
Milestone

Comments

@bschmalhofer
Copy link
Contributor

Local .* files are not meant for the Docker images.
Exceptions to that rule are .bash_aliases and .bash_completion. Check the Dockerfiles.

@bschmalhofer bschmalhofer added this to the OTOBO 10.0.10 milestone Apr 18, 2021
@bschmalhofer bschmalhofer self-assigned this Apr 18, 2021
@bschmalhofer
Copy link
Contributor Author

According to https://docs.docker.com/engine/reference/builder/#dockerignore-file excludes can be declared in the .dockerignore file. There is no minimum version mentionened. So we can ignore all dot-files with the exception of the files that are currently present in the image.

root@f3fe825a0a0c:/opt/otobo_install/otobo_next# ls -lda .*
drwxr-xr-x 1 otobo otobo 4096 Apr 21 17:44 .
drwxr-xr-x 1 root  root  4096 Apr 21 17:44 ..
-rw-r--r-- 1 otobo otobo   21 Apr 21 17:44 .bash_aliases
-rw-rw---- 1 otobo otobo 1453 Apr 21 16:52 .bash_completion
-rw-rw---- 1 otobo otobo 1604 Apr 21 16:52 .fetchmailrc.dist
-rw-rw---- 1 otobo otobo 2181 Apr 21 16:52 .mailfilter.dist
-rw-rw---- 1 otobo otobo 2478 Apr 21 16:52 .procmailrc.dist
-rw-rw---- 1 otobo otobo 1097 Apr 21 16:52 .screenrc
-rwxr-xr-x 1 otobo otobo  298 Apr 21 17:44 .vimrc

Exceptions to the exeptions are .bashrc and .vimrc which are created in a step of the Dockerfile.

bschmalhofer added a commit that referenced this issue Apr 28, 2021
But allow for some exceptions.
bschmalhofer added a commit that referenced this issue Apr 28, 2021
@bschmalhofer
Copy link
Contributor Author

Toplevel .* files are now ignored. Testsuite still looks fine. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants