Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 111 connection #113

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Issue 111 connection #113

merged 2 commits into from
Jun 26, 2020

Conversation

bschmalhofer
Copy link
Contributor

No description provided.

@bschmalhofer bschmalhofer merged commit 3f28b6b into rel-10_0 Jun 26, 2020
bschmalhofer added a commit that referenced this pull request Jul 4, 2020
@bschmalhofer
Issue #113: no need to pass in Directory.
810aedc 
The default value is fine.
bschmalhofer added a commit that referenced this pull request Jul 4, 2020
@bschmalhofer
Issue #113: no need to strip comments
8f9cbf9 
Comments are stripped again in the called sub.
Really parsing the XML file would remove the need for stripping comments.
bschmalhofer added a commit that referenced this pull request Jul 4, 2020
@bschmalhofer
Issue #113: tidying
0208b44 
The match operator returns a list of the matches.
An open call does not create an extra scope. Therefore no need to predeclare $FH.
Use push for appending elements to an array.
@bschmalhofer bschmalhofer deleted the issue-111-connection_id branch July 14, 2020 07:23
bschmalhofer added a commit that referenced this pull request Jul 17, 2020
@bschmalhofer
Issue #113: no need to pass in Directory.
83ed5a9 
The default value is fine.
bschmalhofer added a commit that referenced this pull request Jul 17, 2020
@bschmalhofer
Issue #113: no need to strip comments
c4244e7 
Comments are stripped again in the called sub.
Really parsing the XML file would remove the need for stripping comments.
bschmalhofer added a commit that referenced this pull request Jul 17, 2020
@bschmalhofer
Issue #113: tidying
6b934df 
The match operator returns a list of the matches.
An open call does not create an extra scope. Therefore no need to predeclare $FH.
Use push for appending elements to an array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bschmalhofer