Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1234 quick install #1235

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Issue #1234 quick install #1235

merged 4 commits into from
Sep 16, 2021

Conversation

bschmalhofer
Copy link
Contributor

No description provided.

@bschmalhofer
Issue #1234: tidying
837bb20 
Conform to the code policy. Avoid reusing variable names.
Empty line before 'return'.
@bschmalhofer
Issue #1234: enhance the sample code in the POD
20d5d88
@bschmalhofer
Issue #1234: Add and use Kernel::System::Elasticsearch::ActivateElast…
688be13 
…icsearch()
@bschmalhofer
Copy link
Contributor Author

installer.pl should be tested before applying this PR.

@bschmalhofer
Issue #1234: trick the CodePolicy
c7efab4 
into not replacing 'foreach' by 'for'.
@bschmalhofer
Copy link
Contributor Author

Tried the three relevant variants:

  • quick_setup.pl with --activate-elasticsearch
  • quick_setup.pl without --activate-elasticsearch
  • installer.pl, activating ElasticSearch per Default

These variants worked fine. Got the expected errors, in the two cases with active ES, when running scripts/test/Ticket.t. Looks good. Merging the PR now.

@bschmalhofer bschmalhofer merged commit b80de58 into rel-10_0 Sep 16, 2021
@bschmalhofer bschmalhofer deleted the issue-#1234-quick_install branch September 16, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bschmalhofer