Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #545: use the already open file handle #1480

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Issue #545: use the already open file handle #1480

merged 1 commit into from
Dec 4, 2021

Conversation

bschmalhofer
Copy link
Contributor

enhance code comments
more meaningful variable names

@bschmalhofer
Issue #545: use the already open file handle
b4678ff 
enhance code comments
more meaningful variable names
@bschmalhofer bschmalhofer merged commit 7caa4ff into rel-10_1 Dec 4, 2021
@bschmalhofer bschmalhofer deleted the issue-#545-consistent_use_of_FileTemp branch December 4, 2021 13:25
@bschmalhofer
Copy link
Contributor Author

There was an inconstent usage of the file handle returned from Kernel::System::FileTemp::TempFile(). The applied PR aligns the usage in Kernel/Modules/AgentTicketAttachments.pm with the saner usage Kernel/System/Crypt/PGP.pm, A test with the formatter wc -l gave the expected result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bschmalhofer