Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2630 df indices #2672

Closed
wants to merge 2 commits into from
Closed

Issue #2630 df indices #2672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb0f253
Issue #2630: Fixed multivalue index handling for dynamic fields.
stefanhaerter Nov 14, 2023
32b1a0a
Issue #2630: Aligned code structure with other modules.
stefanhaerter Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Kernel/Modules/AgentTicketPhone.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2250,12 +2250,9 @@ sub Run {
|| $DynFieldStates{Fields}{$Index}{PossibleValues}
);

# TODO: Not necessary anymore
my $Name = $i ? "DynamicField_$DynamicFieldConfig->{Name}_$i" : "DynamicField_$DynamicFieldConfig->{Name}";

# add dynamic field to the list of fields to update
push @DynamicFieldAJAX, {
Name => $Name,
Name => "DynamicField_$DynamicFieldConfig->{Name}_$i",
Data => $DataValues,
SelectedID => $GetParam{DynamicField}{"DynamicField_$DynamicFieldConfig->{Name}"}[$i],
Translation => $DynamicFieldConfig->{Config}->{TranslatableValues} || 0,
Expand Down
4 changes: 1 addition & 3 deletions Kernel/Modules/AgentTicketProcess.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,11 +659,9 @@ sub _RenderAjax {
Value => [ $Param{GetParam}{"DynamicField_$DynamicFieldConfig->{Name}"}[$i] ],
) || \%PossibleValues;

my $Name = "DynamicField_$DynamicFieldConfig->{Name}_$i";

# add dynamic field to the list of fields to update
push @JSONCollector, {
Name => $Name,
Name => "DynamicField_$DynamicFieldConfig->{Name}_$i",
Data => $DataValues,
SelectedID => $Param{GetParam}{"DynamicField_$DynamicFieldConfig->{Name}"}[$i],
Translation => $DynamicFieldConfig->{Config}->{TranslatableValues} || 0,
Expand Down
4 changes: 1 addition & 3 deletions Kernel/Modules/CustomerTicketMessage.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,11 +1342,9 @@ sub Run {
|| $DynFieldStates{Fields}{$Index}{PossibleValues}
);

my $Name = $i ? "DynamicField_$DynamicFieldConfig->{Name}_$i" : "DynamicField_$DynamicFieldConfig->{Name}";

# add dynamic field to the list of fields to update
push @DynamicFieldAJAX, {
Name => $Name,
Name => "DynamicField_$DynamicFieldConfig->{Name}_$i",
Data => $DataValues,
SelectedID => $GetParam{DynamicField}{"DynamicField_$DynamicFieldConfig->{Name}"}[$i],
Translation => $DynamicFieldConfig->{Config}->{TranslatableValues} || 0,
Expand Down
4 changes: 1 addition & 3 deletions Kernel/Modules/CustomerTicketProcess.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,9 @@ sub _RenderAjax {
Value => [ $Param{GetParam}{"DynamicField_$DynamicFieldConfig->{Name}"}[$i] ],
) || $PossibleValues;

my $Name = $i ? "DynamicField_$DynamicFieldConfig->{Name}$Self->{IDSuffix}_$i" : "DynamicField_$DynamicFieldConfig->{Name}$Self->{IDSuffix}";

# add dynamic field to the list of fields to update
push @JSONCollector, {
Name => $Name,
Name => "DynamicField_$DynamicFieldConfig->{Name}$Self->{IDSuffix}_$i",
Data => $DataValues,
SelectedID => $Param{GetParam}{"DynamicField_$DynamicFieldConfig->{Name}"}[$i],
Translation => $DynamicFieldConfig->{Config}->{TranslatableValues} || 0,
Expand Down
Loading