-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify testing logic to immediately return if any of the simultaneous pings succeed #12
Comments
is this online? |
Unfortunately not, the PR is just sitting there. I'm waiting as well because I don't like to rely on my own fork (but that's what I do right now). |
@RounakTadvi are you here? |
Any updates? |
will be available at pub.dev ? |
Is this now added to pub dev? |
Yes, it's available on pub.dev |
Thank you |
Make sure you thank the contributors as well @abdimussa87 😀 |
@MrCsabaToth Thank you |
@RounakTadvi How can we change the interval where the checking for internet connection happens from 10 seconds to 5 second or so? |
@abdimussa87 Can you open a StackOverflow question and link it here? I'll answer there. |
Currently the logic is "All addresses are pinged simultaneously. ... When all the requests complete with either success or failure, a check is made to see if the list contains at least one true boolean.". However if any of the hosts slow to respond (for example for some reason CloudFlare DNSes don't respond (komapeb/data_connection_checker#10 (comment)) then we have to wait a timeout (10 seconds, which is excruciating for a user, given that some pings may have already succeeded). In my opinion if any of the pings succeed then the test could already cut short any other pings and return immediately.
The text was updated successfully, but these errors were encountered: