Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify testing logic to immediately return if any of the simultaneous pings succeed #12

Closed
MrCsabaToth opened this issue Jul 29, 2021 · 13 comments

Comments

@MrCsabaToth
Copy link
Contributor

Currently the logic is "All addresses are pinged simultaneously. ... When all the requests complete with either success or failure, a check is made to see if the list contains at least one true boolean.". However if any of the hosts slow to respond (for example for some reason CloudFlare DNSes don't respond (komapeb/data_connection_checker#10 (comment)) then we have to wait a timeout (10 seconds, which is excruciating for a user, given that some pings may have already succeeded). In my opinion if any of the pings succeed then the test could already cut short any other pings and return immediately.

@madatr
Copy link

madatr commented Aug 24, 2021

is this online?

@MrCsabaToth
Copy link
Contributor Author

is this online?

Unfortunately not, the PR is just sitting there. I'm waiting as well because I don't like to rely on my own fork (but that's what I do right now).

@MrCsabaToth
Copy link
Contributor Author

@RounakTadvi are you here?

@abdimussa87
Copy link

Any updates?

RounakTadvi added a commit that referenced this issue Oct 3, 2021
@IonVillarreal
Copy link

will be available at pub.dev ?

@abdimussa87
Copy link

Is this now added to pub dev?

@RounakTadvi
Copy link
Owner

Yes, it's available on pub.dev

@abdimussa87
Copy link

Thank you

@RounakTadvi
Copy link
Owner

Make sure you thank the contributors as well @abdimussa87 😀

@abdimussa87
Copy link

@MrCsabaToth Thank you

@abdimussa87
Copy link

@RounakTadvi How can we change the interval where the checking for internet connection happens from 10 seconds to 5 second or so?

@MrCsabaToth
Copy link
Contributor Author

How can we change the interval where the checking for internet connection happens from 10 seconds to 5 second or so?

@abdimussa87 Can you open a StackOverflow question and link it here? I'll answer there.

@abdimussa87
Copy link

@MrCsabaToth here you go https://stackoverflow.com/questions/69524223/how-to-change-the-interval-where-checking-for-internet-connection-happens-from-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants