-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hyper crates versions #12
Conversation
Hey @kirhgoff, thank you so much for your work :) I will merge your branch as soon as tests do pass! |
@RoxasShadow yeah I am stuck a little bit with passing data from futures. Will do another effort this weekend. |
@RoxasShadow I think the fix is ready (though I haven't tested it yet in a real app, going to do it on weekend). The main problem was to find how this new hyper version is supposed to be used, they have very slim doco and all examples just print what they receive from server and do not return it. Method I would appreciate if you will merge PR with "Squash and merge" action, I wasn't formulating my comments when was working, and don't like doing rebase, squash and merge from Github UI works perfectly. I changed the description so it could be pasted into a git commit comment. |
Thank you! I will publish the updated crate in the following days! |
Published on crates.io as |
Adding
rollbar = "0.5.1"
crate to Cargo.toml makes project fail to compileError
Cause
from here paritytech/substrate#800
the problem is my openssl version is 1.1.1
it is not supported by
0.9.x of openssl crate :
https://github.com/sfackler/rust-openssl/blob/0.9.x/openssl/build.rs#L16
the problem is fixed in newer version of openssl crate :
https://github.com/sfackler/rust-openssl/blob/master/openssl/build.rs#L33
Solution
Use the last version of the hyper crate. Replace hyper-openssl crate with hyper-tls.