Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook story source code isn't being generated correctly #2811

Closed
jpveooys opened this issue Nov 17, 2021 · 1 comment · Fixed by #2813
Closed

Storybook story source code isn't being generated correctly #2811

jpveooys opened this issue Nov 17, 2021 · 1 comment · Fixed by #2813
Assignees
@jpveooys
Labels
Package: react-component-library Package/code type Size: Small Assessed as small task Type: Bug Inconsistencies or issues which have caused a problem for users or implementors

Comments

@jpveooys
Copy link
Collaborator

Steps to reproduce

  1. Go to e.g. https://storybook.design-system.digital.mod.uk/?path=/docs/button-experimental--default
  2. Click on the code button

The source code isn't generated correctly:

image

However, this is supposed to work: storybookjs/storybook#11332

It can also be seen working in this example here:
https://next--storybookjs.netlify.app/official-storybook/?path=/docs/docs-source--loading

We need to investigate why it's not working in this project.
@jpveooys jpveooys added Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Package: react-component-library Package/code type Size: Medium Assessed as medium task labels Nov 17, 2021
@jpveooys jpveooys added Size: Small Assessed as small task and removed Size: Medium Assessed as medium task labels Nov 17, 2021
@jpveooys
Copy link
Collaborator Author

It looks like it's been turned off here: https://github.com/defencedigital/mod-uk-design-system/blob/master/packages/react-component-library/.storybook/preview.js#L35

So we just need to check if there's any reason for that and if it can be turned on safely.

@jpveooys jpveooys changed the title Storybook story source code isn't being genreated correctly Storybook story source code isn't being generated correctly Nov 17, 2021
@jpveooys jpveooys self-assigned this Nov 17, 2021
@jpveooys jpveooys mentioned this issue Nov 17, 2021
Merged
4 tasks
@m7kvqbe1 m7kvqbe1 moved this to Done in Tactical Board Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpveooys jpveooys

Labels
Package: react-component-library Package/code type Size: Small Assessed as small task Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
Tactical Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(Storybook): Enable dynamic source code generation Royal-Navy/design-system
1 participant
@jpveooys