-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Dynamic Source rendering for React #11332
Conversation
Merging this and releasing so that React users can start trying it out to keep things moving. |
I love this, and would love it even more, if you could switch to the HTML output as well somehow! ❤️ |
@shilman is there an open issue that's tracking progress for non-React frameworks? Specifically, I'm looking for the code block to work with the web components build. (Many thanks for all of your work on this project! We're really digging it at Filament Group so far.) |
Thanks @maggiewachs! There is now 😅 #11588 I had somebody else ask about lit-element support yesterday & volunteer to contribute, so hopefully we can get that going in 6.1 |
It will be really useful @shilman, great!! ❤️ I was thinking about it today. |
Issue: #8342 #8444
What I did
Work in progress for rendering JSX in the code snippet, based on https://github.com/storybookjs/addon-jsx (cc @hipstersmoothie). Now, for React (and eventually all view layers), the JSX of the story function output is rendered to an example snippet dynamically.
This solves the following issues:
Story.bind({})
source for args storiesStill to be done:
memo
andref
sWhat I need
How to test
See
official-storybook