fix(ProgressIndicator): Avoid downstream runtime warning from Next.js #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7kvqbe1
added
Type: Bug
✅ Deploy Preview for storybook-navy-digital-mod-uk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m7kvqbe1
force-pushed
the
fix/transform-origin-svg-attribute-next-runtime-error
branch
from
a9afe74 to
3505d1d
Compare
markhigham
approved these changes
May 1, 2024
m7kvqbe1
force-pushed
the
fix/transform-origin-svg-attribute-next-runtime-error
branch
from
3505d1d to
e7c32a2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #3714
Overview
Apply via css property in keyframe definition to avoid inline
transform-originupon on transpilation.Reason
Next.js is wrongly throwing a runtime warning about the
transform-originSVG attribute.This is a valid HTML SVG attribute.
Work carried out
transform-originusageloader.svgcode formattingScreenshot
Developer notes
vercel/next.js#53342 (comment)
https://github.com/facebook/react/pull/26130/files#diff-67b481b96d526280780f010dfd192761f2d1f6dc812e3015020a7986501d2ebaR524