Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support get reset ls for openEuler and measure upstream by default #159

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

ccmywish
Copy link
Contributor

描述

  • 问题的背景

    openEuler 提供完善的支持

  • 相关Issue

    openeuler 换源失败 #156

  • 这个PR做了什么

    • 默认对上游源测速
    • 添加了 get 的支持
    • 添加了 reset 的支持
    • 添加了 ls 的支持

方案

上游源测试地址来自于:https://repo.openeuler.org/openEuler-24.03-LTS/ISO/x86_64/

我找了一个大小合适的链接供测速


实现

实现很直接,不再赘述


注意

无特别注意事项


测试

chsrc measure openeuler
chsrc get openeuler
chsrc reset openeuler
chsrc ls openeuler

@ccmywish ccmywish requested a review from happy-game December 18, 2024 09:10
@ccmywish ccmywish added 改善加强 改善加强 os_target os target labels Dec 18, 2024
@ccmywish ccmywish added this to the v0.2.0 milestone Dec 18, 2024
@ccmywish ccmywish self-assigned this Dec 18, 2024
src/recipe/os/YUM/openEuler.c Show resolved Hide resolved
src/recipe/os/YUM/openEuler.c Outdated Show resolved Hide resolved
@ccmywish
Copy link
Contributor Author

ccmywish commented Dec 18, 2024

因为上游源我们依然搜集的太少(#111),而且上游源的正确性几位提交者并没有真正验证过,可能有错,而且上游源的URL每个软件都不一样,没有规律可言,并有可能之后还会发生变动。

所以我们显示出来的目的,是为了让某些熟知上游源的用户能立刻发现问题,进行纠正。

Debian 的那个恰恰是因为,还没有实现对 Debian 默认上游源测速,之后会改。

这里分别对英文和中文用的是第二个和第三个字段:

"upstream", "https://repo.openeuler.org/", "上游默认源 https://repo.openeuler.org/", "https://repo.openeuler.org/"

image

image

@happy-game
Copy link
Collaborator

原来是这样, 我对这里的设计不是很了解, 只是测试chsrc ls openeuler时发现镜像源的输出没有对齐, 所有就参考了其他的实现.

@happy-game happy-game merged commit f57655c into RubyMetric:dev Dec 18, 2024
@ccmywish
Copy link
Contributor Author

ccmywish commented Dec 18, 2024

你说的对,我没有想到 ls 没对齐 👍

开源协作的一大好处就是,总有人能从不同的方面,不同的视角提醒我们的实现,感谢你的指出 ❤️

打算实现成这个样子:

image

image

image

@happy-game
Copy link
Collaborator

我赞同这么实现

ccmywish added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os_target os target 改善加强 改善加强
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants