Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed our recipe hash into a hash that that describes a Train. #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adamxlowe
Copy link

No description provided.

@jwo
Copy link
Member

jwo commented Dec 2, 2013

Looks great.

I do think this exercise shows one note:

train = Train.new("Los Angeles", 1, 15, 1)

Looking at this method, its extremely hard to tell what is what.

We can change this to this for readability:

train = Train.new("Los Angeles", engines=1, cars=15, caboose=1)

thoughts?

@adamxlowe
Copy link
Author

It does make reading it a lot more clear. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants