"Source name"-field in NAS Mounts influences mount process

[STPKITT]

Hello,
I just found out, that the field "Source name" seems to accidently interact with the mount process instead of just naming the Source name to show that name in the "Network Mounts" list.
For example when I just type the word "Test" into the "Source Name"-field the mount is successfull. But when I name the source for example "//APGen2VDR/Audio/Musik" or "//APGen2VDR" or "APGen2VDR/Audio/Musik" it can't mount the share. The error it shows is:
Couldn't chdir to /mnt/MPD/NAS///APGen2VDR/Audio/Musik: No such file or directory
As soon as you use the "/"-symbol in the "Source name"-field the mount fails. So cleary, the field "Source name" does interact with the mount itself, which it clearly should not do!

EDIT: BTW I wanted to submit at text-file containing the debug data, but I'm missing write permission to this repo.

[ACXgit]

We hadn't thought in the eventuality that somebody could use slashes in the "Source name" field :) So we should add a validation check for that field, forbidding the use of special characters. Thank you for spotting the issue.

[STPKITT]

:-) I'm glad to help this little bit to improve this great project. But I don't understand why the "Source name" field does interact with the mounting process at all!
In my opinion this shouldn't be fixed by just forbidding certain characters for the "Source name" field but by disabling any interaction of the field with the mouting process, which I want to stress again I can't see why any kind of action triggered by the "Source name"-field is useful/needed at all. As I'm no programmer I may be missing the point here and if that's the case I would be really interested in a explanation.
BTW the reason I entered a complete pathname with the slashes into the field is because since years I'm used to do it that way from using Kodi, the home theater software, where I always had to configure many media sources, because of a lack of a central NAS, so I wanted to give every source the most exact name.

[kdubious]

The command we run to mount a source includes the Source Name, so we can reference it by name later. That command doesn't tolerate a "/" in the source name evidently.

Without looking at code, I'm not sure if we can allow slashes in source names. (This isn't such a strange requirement, limiting the names of things to certain valid characters. Consider in most operating systems, certain characters aren't permitted in file names, for example.)

---

From: STPKITTmailto:notifications@github.com
Sent: ‎10/‎21/‎2015 9:12 PM
To: RuneAudio/RuneUImailto:RuneUI@noreply.github.com
Subject: Re: [RuneUI] "Source name"-field in NAS Mounts influences mount process (#70)

:-) I'm glad to help this little bit to improve this great project. But I don't understand why the "Source name" field does interact with the mounting process at all!
In my opinion this shouldn't be fixed by just forbidding certain characters for the "Source name" field but by disabling any interaction of the field with the mouting process, which I want to stress again I can't see why any kind of action triggered by the "Source name"-field is useful/needed at all. As I'm no programmer I may be missing the point here and if that's the case I would be really interested in a explanation.
BTW the reason I entered a complete pathname with the "/"s into the field is because since years I'm used to do it that way from using Kodi, the home theater software, where I always had to configure many media sources, because of a lack of a central NAS, so I wanted to give every source the most exact name.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/70#issuecomment-150069450.

[STPKITT]

Ok, thanks, I understand the background now. Maybe you could assign a number to every source name and reference the numbers then.
Being able to use slashes in source names is by no means an absolute must have, but it would still be very nice.