Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache ergonomics #28

Closed
wants to merge 8 commits into from
Closed

Improve cache ergonomics #28

wants to merge 8 commits into from

Conversation

CohenArthur
Copy link
Member

This PR does multiple things as I was stuck on a train without internet:

  1. Add an /api/dates route to indicate all dates recorded in the cache
  2. Add ways to write cache to disk
  3. Add ways to load cache from disk
  4. Add mocking to test the cache even when making requests is not possible (heh)

@CohenArthur
Copy link
Member Author

This still has a few issues:

  • Does not save cache data properly (file names are missing a date)
  • Does not try to update the cache from the local cache properly (does not update its latest date etc)

@CohenArthur
Copy link
Member Author

Closing since #32 has been merged

@CohenArthur CohenArthur closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant