Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement eager expansion for option_env!() #1806

Closed
Tracked by #1791
CohenArthur opened this issue Feb 1, 2023 · 2 comments · Fixed by #3094
Closed
Tracked by #1791

Implement eager expansion for option_env!() #1806

CohenArthur opened this issue Feb 1, 2023 · 2 comments · Fixed by #3094
Assignees
@ptdatta
Labels
enhancement
Milestone
core 1.49 functio...

Comments

@CohenArthur
Copy link
Member

No description provided.

@CohenArthur CohenArthur mentioned this issue Feb 1, 2023
Open
10 tasks
@github-project-automation github-project-automation bot moved this to Additional sprint items in libcore 1.49 Feb 1, 2023
@CohenArthur CohenArthur added this to the Final upstream patches milestone Feb 1, 2023
@ptdatta
Copy link
Contributor

ptdatta commented Feb 7, 2023

@CohenArthur Can I work on this?

@CohenArthur
Copy link
Member Author

Sure thing @Parthib314 :) thanks

@CohenArthur CohenArthur moved this from Additional sprint items to Todo in libcore 1.49 Feb 15, 2023
@CohenArthur CohenArthur moved this from Todo to In Progress in libcore 1.49 Feb 15, 2023
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 21, 2024
@liamnaddell
Rust-GCC#1806 experiment with solution, code doesn't compile
79a196c
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 21, 2024
@liamnaddell
Rust-GCC#1806 I wrote up a better version, but eagar expansion doesn…
ab1e012 
…'t work
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 22, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
498b569 
    gcc/rust/ChangeLog:
            * expand/rust-macro-builtins-utility.cc:
	    Add macro expansion for option_env with eager expansion
            * expand/rust-macro-builtins.cc:
	    Add option_env to builtin list
            * expand/rust-macro-builtins.h:
	    Add option_env handler to header file

    gcc/testsuite/ChangeLog:
            * rust/compile/option_env1.rs:
	    Add success case for option_env
            * rust/compile/option_env2.rs:
	    Add failure case for option_env
            * rust/execute/torture/builtin_macro_option_env.rs:
	    Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 22, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
1fc99ec 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
@liamnaddell liamnaddell mentioned this issue Jul 22, 2024
Merged
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 23, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
21c43ec 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 23, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
820939e 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 23, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
6262158 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 23, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
62a89ef 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 24, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
20d7b4b 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 26, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
c8c983e 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 26, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
0c6d2d8 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 31, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
3d8baf7 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/option_env1.rs:
	Add success case for option_env
	* rust/compile/option_env2.rs:
	Add failure case for option_env
	* rust/compile/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 31, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
ad53773 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/macros/bultin/option_env1.rs:
	Add success case for option_env
	* rust/compile/macros/bultin/option_env2.rs:
	Add failure case for option_env
	* rust/compile/macros/bultin/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 31, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
8350b2c 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/macros/builtin/option_env1.rs:
	Add success case for option_env
	* rust/compile/macros/builtin/option_env2.rs:
	Add failure case for option_env
	* rust/compile/macros/builtin/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Aug 1, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
dd8612c 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/macros/builtin/option_env1.rs:
	Add success case for option_env
	* rust/compile/macros/builtin/option_env2.rs:
	Add failure case for option_env
	* rust/compile/macros/builtin/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Aug 6, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
36cd2a3 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/macros/builtin/option_env1.rs:
	Add success case for option_env
	* rust/compile/macros/builtin/option_env2.rs:
	Add failure case for option_env
	* rust/compile/macros/builtin/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Aug 8, 2024
@liamnaddell
[ Rust-GCC#1806 ] Add option_env support
2034102 
gcc/rust/ChangeLog:
	* expand/rust-macro-builtins-utility.cc:
	Add macro expansion for option_env with eager expansion
	* expand/rust-macro-builtins.cc:
	Add option_env to builtin list
	* expand/rust-macro-builtins.h:
	Add option_env handler to header file

gcc/testsuite/ChangeLog:
	* rust/compile/macros/builtin/option_env1.rs:
	Add success case for option_env
	* rust/compile/macros/builtin/option_env2.rs:
	Add failure case for option_env
	* rust/compile/macros/builtin/option_env3.rs:
	Add second failure case for option_env
	* rust/execute/torture/builtin_macro_option_env.rs:
	Add execution case for option_env

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jan 13, 2025
@liamnaddell
[Rust-GCC#1806] option_env! support
8f2f513 
get from ast to hir, but continue finding resolution errors inside hir

fix type resolution issues, now stuck with type inference issues

get past type nonsense, die in marklive

it compiles

e
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jan 13, 2025
@liamnaddell
[Rust-GCC#1806] option_env! support
b80133e 
get from ast to hir, but continue finding resolution errors inside hir

fix type resolution issues, now stuck with type inference issues

get past type nonsense, die in marklive

it compiles

e
@github-project-automation github-project-automation bot moved this from In Progress to Done in libcore 1.49 Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptdatta ptdatta

Labels
enhancement
Projects
libcore 1.49
Status: Done
Milestone
core 1.49 functionality [AST]
Development

Successfully merging a pull request may close this issue.

Add option_env support liamnaddell/gccrs
2 participants
@CohenArthur @ptdatta