-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Field Error Function into one Function #2336
Labels
Comments
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 28, 2023
Refactored field error function into one function, to make easier error emission. Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored field error function (TypeCheckPattern::visit): called 'emit_invalid_field_error' function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
2 tasks
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 28, 2023
Refactored field error function into one function, to make easier error emission. Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored field error function (TypeCheckPattern::visit): called 'emit_invalid_field_error' function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 28, 2023
Refactored field error function into one function, to make easier error emission. Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored field error function (TypeCheckPattern::visit): called 'emit_invalid_field_error' function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 28, 2023
Refactored field error function into one function, to make easier error emission. Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored field error function (TypeCheckPattern::visit): called 'emit_invalid_field_error' function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 28, 2023
Refactored field error function into one function, to make easier error emission. Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored field error function (TypeCheckPattern::visit): called 'emit_invalid_field_error' function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 29, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 29, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 29, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 29, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 29, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
added a commit
to MahadMuhammad/gccrs
that referenced
this issue
Jun 29, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 30, 2023
Refactored field error function into one funciton Fixes #2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
moved this to Refactor Done
in Error Code Support & Improving User Errors
Jul 15, 2023
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Nov 15, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Nov 21, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Nov 21, 2023
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 5, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 8, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 9, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 9, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 9, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 9, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 9, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 9, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 11, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 12, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 16, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 16, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
CohenArthur
pushed a commit
to CohenArthur/gccrs
that referenced
this issue
Jan 17, 2024
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refactoring Field Error Function
Originally posted by @CohenArthur in #2326 (comment)
gccrs/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
Lines 204 to 212 in 5711a2a
gccrs/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
Lines 225 to 233 in 5711a2a
The text was updated successfully, but these errors were encountered: