Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor helper functions around attributes #3291

Open
CohenArthur opened this issue Dec 4, 2024 · 2 comments
Open

Refactor helper functions around attributes #3291

CohenArthur opened this issue Dec 4, 2024 · 2 comments

Comments

@CohenArthur
Copy link
Member

CohenArthur commented Dec 4, 2024

We should introduce some helper function here instead, I'm sure it would be reused elsewhere and it would ease this function a bit.
Probably within rust-attributes.cc since we already have some similar functions there ?

Originally posted by @P-E-P in #3289 (comment)

There are plenty of places where attributes are being checked or used and a lot of repetition is happening. We have just added an Attributes class to rust-attributes.cc, and it would be nice to collect functions related to attributes in that class.

@saeitoshi-10
Copy link

Hi, I am interested in working on this issue, but I am new here and need some guidance. Could you please point me to where the implementation for the attributes can be found in the codebase? Any relevant files, functions, or documentation would be really helpful.

Thank you for your time and support, and apologies if this is a basic question!

@saeitoshi-10
Copy link

@CohenArthur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants